Skip to content

refactor(parser): import from std at top level#20737

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-23-refactor_parser_import_from_std_at_top_level
Mar 25, 2026
Merged

refactor(parser): import from std at top level#20737
graphite-app[bot] merged 1 commit intomainfrom
om/03-23-refactor_parser_import_from_std_at_top_level

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Mar 25, 2026

Pure refactor. Import from std at top level, to shorten code elsewhere.

Copy link
Copy Markdown
Member Author

overlookmotel commented Mar 25, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 25, 2026
@overlookmotel overlookmotel marked this pull request as ready for review March 25, 2026 15:37
Copilot AI review requested due to automatic review settings March 25, 2026 15:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the parser’s modifiers module to import std::fmt items at the top level, reducing repeated fully-qualified std::fmt::* paths in Display implementations.

Changes:

  • Import std::fmt::{self, Display} at module scope.
  • Update Display impls to use fmt::Formatter / fmt::Result and the in-scope Display trait.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 25, 2026

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/03-23-refactor_parser_import_from_std_at_top_level (7f93983) with main (b02fe6e)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/03-23-refactor_parser_remove_modifier_is_static_ (5c42fe9) during the generation of this report, so main (b02fe6e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026
Copy link
Copy Markdown
Contributor

camc314 commented Mar 25, 2026

Merge activity

  • Mar 25, 5:15 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 5:24 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Mar 25, 6:08 PM UTC: This pull request was removed from the Graphite merge queue because the batch it was included in timed out. Please re-enqueue the PR to retry merge.
  • Mar 25, 6:28 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 7:05 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Mar 25, 7:10 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from om/03-23-refactor_parser_remove_modifier_is_static_ to graphite-base/20737 March 25, 2026 17:18
graphite-app bot pushed a commit that referenced this pull request Mar 25, 2026
Pure refactor. Import from `std` at top level, to shorten code elsewhere.
@graphite-app graphite-app bot force-pushed the om/03-23-refactor_parser_import_from_std_at_top_level branch from 7f93983 to f9d016b Compare March 25, 2026 17:35
@graphite-app graphite-app bot changed the base branch from graphite-base/20737 to om/03-23-refactor_parser_remove_modifier_is_static_ March 25, 2026 17:35
Base automatically changed from om/03-23-refactor_parser_remove_modifier_is_static_ to main March 25, 2026 17:38
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2026
@overlookmotel overlookmotel force-pushed the om/03-23-refactor_parser_import_from_std_at_top_level branch from f9d016b to e8a9a3c Compare March 25, 2026 19:01
@overlookmotel overlookmotel self-assigned this Mar 25, 2026
Pure refactor. Import from `std` at top level, to shorten code elsewhere.
@graphite-app graphite-app bot force-pushed the om/03-23-refactor_parser_import_from_std_at_top_level branch from e8a9a3c to 14868fb Compare March 25, 2026 19:06
@graphite-app graphite-app bot merged commit 14868fb into main Mar 25, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants