refactor(parser): rename ModifierFlags to ModifierKinds

[overlookmotel]

Pure refactor. Rename ModifierFlags to ModifierKinds. This type represents a collection of ModifierKinds, and after #20738 it's no longer implemented as bitflags!, so the name is no longer appropriate.

This PR is pure renaming - rename the type, and variables that hold the type.

[overlookmotel]

• perf(parser): defer calculation of Modifier spans #20823 : 2 dependent PRs (#20824 , #20826 )
• perf(parser): remove branch from parse_modifiers #20821
• perf(parser): reduce Kind to ModifierKind conversions in eat_modifiers_before_declaration #20820
• refactor(parser): shorten code handling illegal modifiers #20781
• perf(parser): fast path for no syntax errors when checking modifiers #20748
• perf(parser): remove a lookahead from eat_modifiers_before_declaration #20755
• refactor(parser): nest modifiers types in modules #20754
• refactor(parser): re-order modifiers code #20753
• perf(parser): store Modifiers on stack #20742
• perf(parser): add Modifiers::get method #20741
• refactor(parser): rename ModifierKinds::empty to none #20740
• refactor(parser): rename ModifierFlags to ModifierKinds #20739 👈 (View in Graphite)
• refactor(parser): simplify ModifierFlags #20738
• refactor(parser): import from std at top level #20737
• refactor(parser): remove Modifier::is_static() #20736
• refactor(parser): remove dead code from modifier parsing #20735
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 44 untouched benchmarks
⏩ 12 skipped benchmarks¹

---

_{Comparing om/03-23-refactor_parser_rename_modifierflags_to_modifierkinds_ (0c15f8f) with main (5aee74c)}

Footnotes

1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR updates the TypeScript/JavaScript parser modifier-set type naming to reflect its semantics: renaming ModifierFlags to ModifierKinds now that the representation is no longer a bitflags!-style flags type.

Changes:

• Rename the modifier set type from ModifierFlags to ModifierKinds.
• Update parser call sites and local variables to use ModifierKinds consistently.
• Update diagnostics signatures/helpers that accept “allowed modifiers” sets.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_parser/src/ts/types.rs	Update modifier verification call sites to use ModifierKinds.
crates/oxc_parser/src/ts/statement.rs	Replace ModifierFlags usage/imports with ModifierKinds in TS statement parsing.
crates/oxc_parser/src/modifiers.rs	Rename the core modifier-set type and propagate the rename through parsing/validation logic and stored fields.
crates/oxc_parser/src/js/statement.rs	Update enum-const modifier construction to use ModifierKinds.
crates/oxc_parser/src/js/object.rs	Update modifier verification call sites/imports to ModifierKinds.
crates/oxc_parser/src/js/module.rs	Update default export class modifier construction to ModifierKinds.
crates/oxc_parser/src/js/function.rs	Update parameter/function modifier allowlists to ModifierKinds.
crates/oxc_parser/src/js/class.rs	Update class-element modifier allowlists and constants to ModifierKinds.
crates/oxc_parser/src/diagnostics.rs	Update diagnostics helper signatures and imports to accept Option<ModifierKinds>.

[graphite-app]

Merge activity

• Mar 26, 1:08 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 26, 1:13 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
• Mar 26, 1:25 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 26, 1:27 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Mar 26, 1:31 PM UTC: Merged by the Graphite merge queue.

[camc314]

Didnt push any code changes, just restacked, because it ended up with conflicts (somehow)