Skip to content

chore(oxfmt): Add comment for setBlocking(true) #20323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 13, 2026
+7 −3
Merged

chore(oxfmt): Add comment for setBlocking(true) #20323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions apps/oxfmt/src-js/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,17 @@ void (async () => {
const args = process.argv.slice(2);

// Node.js sets non-TTY `stdio` to non-blocking mode,
// which causes `WouldBlock` errors in Rust when writing large output with `--stdin-filepath`.
// https://github.com/oxc-project/oxc/issues/17939 (issue was on macOS)
//
// which causes `WouldBlock` errors in Rust.
// As a workaround, if used with pipe, set blocking mode before calling NAPI bindings.
// See: https://github.com/napi-rs/napi-rs/issues/1630
//
// stdout: Writing large formatted output via `--stdin-filepath` can overflow the pipe buffer.
// https://github.com/oxc-project/oxc/issues/17939 (observed on macOS)
// @ts-expect-error: `_handle` is an internal API
if (!process.stdout.isTTY) process.stdout._handle?.setBlocking?.(true);
// stdin: In LSP mode (`--lsp`), VSCode communicates via stdin/stdout pipes.
// Rust reads stdin expecting blocking I/O, but non-blocking mode returns `EAGAIN` (os error 11).
// https://github.com/oxc-project/oxc/issues/20285
// @ts-expect-error: `_handle` is an internal API
if (!process.stdin.isTTY) process.stdin._handle?.setBlocking?.(true);

Expand Down
Loading