Skip to content

refactor(linter/plugins): re-order visit function merging code#20316

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code
Mar 13, 2026
Merged

refactor(linter/plugins): re-order visit function merging code#20316
graphite-app[bot] merged 1 commit intomainfrom
om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 13, 2026

Pure refactor. Re-order code related to merging visit functions in a more cogent order.

Copy link
Member Author

overlookmotel commented Mar 13, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 13, 2026
@overlookmotel overlookmotel marked this pull request as ready for review March 13, 2026 00:34
@overlookmotel overlookmotel requested a review from camc314 as a code owner March 13, 2026 00:34
Copilot AI review requested due to automatic review settings March 13, 2026 00:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the visitor compilation code by reordering the CFG visit-function merging logic to improve readability while preserving existing behavior.

Changes:

  • Moves Merger / CfgMerger type aliases to a more central location near the merge helpers.
  • Reorders mergeCfgVisitFns to sit alongside mergeVisitFns (AST) for a more coherent flow.

@overlookmotel overlookmotel self-assigned this Mar 13, 2026
@overlookmotel overlookmotel force-pushed the om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions branch from 6e6a360 to 94f4029 Compare March 13, 2026 01:19
@overlookmotel overlookmotel force-pushed the om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code branch from b8e7740 to 2795973 Compare March 13, 2026 01:19
@graphite-app graphite-app bot force-pushed the om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions branch 2 times, most recently from d90493a to 0bb4224 Compare March 13, 2026 01:43
@graphite-app graphite-app bot force-pushed the om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code branch from 2795973 to 9de8395 Compare March 13, 2026 01:43
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 13, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 13, 2026

Merge activity

Pure refactor. Re-order code related to merging visit functions in a more cogent order.
@graphite-app graphite-app bot force-pushed the om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions branch from 0bb4224 to 9163428 Compare March 13, 2026 01:58
@graphite-app graphite-app bot force-pushed the om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code branch from 9de8395 to 2b509f9 Compare March 13, 2026 01:58
Base automatically changed from om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions to main March 13, 2026 02:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 13, 2026
@graphite-app graphite-app bot merged commit 2b509f9 into main Mar 13, 2026
20 checks passed
@graphite-app graphite-app bot deleted the om/03-10-refactor_linter_plugins_re-order_visit_function_merging_code branch March 13, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants