refactor(linter/plugins): combine functions to generate merge functions#20315
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 13, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 13, 2026
github-actions
bot
added
A-linter
This was referenced Mar 13, 2026
github-actions
bot
added
the
C-cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the visitor compiler in apps/oxlint by consolidating separate AST-visit and CFG-event merger generators into a single createMerger implementation, reducing duplicated code while keeping the existing “predefined up to 5” fast paths.
Changes:
- Replaces the separate CFG merger generator with a unified
createMerger(fnCount, isCfg)that emits either(n)=>{...}or(...a)=>{...}dispatch. - Updates dynamic-merger warmup paths for both AST visitors and CFG visitors to use the unified generator.
- Removes the now-redundant
createCfgMergerfunction and documents the generated code shapes.
overlookmotel
changed the base branch from
om/03-10-perf_linter_plugins_move_creating_merger_functions_off_hot_path
to
graphite-base/20315
overlookmotel
force-pushed
the
graphite-base/20315
branch
from
e534f2c to
0e1f716
Compare
overlookmotel
force-pushed
the
om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions
branch
from
6e6a360 to
94f4029
Compare
graphite-app
bot
force-pushed
the
om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions
branch
from
94f4029 to
d90493a
Compare
graphite-app
bot
force-pushed
the
graphite-base/20315
branch
from
0e1f716 to
3b9eb28
Compare
graphite-app
bot
force-pushed
the
om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions
branch
from
d90493a to
0bb4224
Compare
Contributor
Merge activity
|
…ns (#20315) Previously we had 2 functions specialized for generating merger functions for AST node visit functions and CFG event handler functions. Merge them into 1. This reduces the amount of code and makes it clearer.
graphite-app
bot
force-pushed
the
om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions
branch
from
0bb4224 to
9163428
Compare
graphite-app
bot
deleted the
om/03-10-refactor_linter_plugins_combine_functions_to_generate_merge_functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we had 2 functions specialized for generating merger functions for AST node visit functions and CFG event handler functions. Merge them into 1. This reduces the amount of code and makes it clearer.