fix(oxlint,oxfmt): Skip vite.config.ts exports defineConfig(fn)#20260
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
changed the title
vite.config.ts exports defineConfig(fn)
Contributor
There was a problem hiding this comment.
Pull request overview
Updates oxlint/oxfmt JS config loading to tolerate vite.config.ts default exports that are functions (e.g. defineConfig(fn)) by skipping them during config discovery, and adds fixtures/tests to lock in the behavior.
Changes:
- oxlint: treat non-object
vite.config.tsdefault exports as “skip config” (config: null) instead of throwing. - oxfmt: treat non-object
vite.config.tsdefault exports as “skip config” (null) instead of throwing. - Add new fixtures + snapshot coverage for the function-export vite config case in both projects.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src-js/js_config.ts | Skip vite.config.ts when default export isn’t an object; reuse helper for object checks. |
| apps/oxlint/test/fixtures/vite_config_fn_export/vite.config.ts | Fixture vite config exporting defineConfig(fn). |
| apps/oxlint/test/fixtures/vite_config_fn_export/output.snap.md | Expected fixture output snapshot. |
| apps/oxlint/test/fixtures/vite_config_fn_export/options.json | Fixture options (single-threaded). |
| apps/oxlint/test/fixtures/vite_config_fn_export/files/test.js | Fixture input file triggering a warning. |
| apps/oxfmt/src-js/cli/js_config.ts | Skip vite.config.ts when default export isn’t an object; validate .fmt only on objects. |
| apps/oxfmt/test/cli/vite_config/vite_config.test.ts | Add test case for skipping function-export vite config during auto-discovery. |
| apps/oxfmt/test/cli/vite_config/fixtures/skip_fn_export/vite.config.ts | Fixture vite config exporting defineConfig(fn). |
| apps/oxfmt/test/cli/vite_config/fixtures/skip_fn_export/test.ts | Fixture input file for formatter check. |
| apps/oxfmt/test/cli/vite_config/snapshots/vite_config.test.ts.snap | Snapshot for the new oxfmt test case. |
You can also share your feedback on Copilot code review. Take the survey.
leaysgur
force-pushed
the
03-12-fix_oxlint_oxfmt_skip_vite.config.ts_exports_defineconfig_fn_
branch
from
7caf1cc to
a50928d
Compare
Member
Author
Merge activity
|
graphite-app
bot
changed the base branch from
03-12-refactor_oxfmt_extract_vite_fmt_config_in_js_loader
to
graphite-base/20260
leaysgur
force-pushed
the
03-12-fix_oxlint_oxfmt_skip_vite.config.ts_exports_defineconfig_fn_
branch
from
a50928d to
9474e54
Compare
…20260) `vite.config.ts` may return function from `defineConfig(({ mode }) => ({ ... }))`, but we can't evaluate. Just skip it like no `.lint|fmt` config.
graphite-app
bot
force-pushed
the
03-12-fix_oxlint_oxfmt_skip_vite.config.ts_exports_defineconfig_fn_
branch
from
9474e54 to
4ea67de
Compare
graphite-app
bot
deleted the
03-12-fix_oxlint_oxfmt_skip_vite.config.ts_exports_defineconfig_fn_
branch
leaysgur
added a commit
that referenced
this pull request
Mar 12, 2026
# Oxlint ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - cc89dbf oxlint: Skip `vite.config.ts` w/o `.lint` field in auto-discovery (#20255) (leaysgur) - 89b7ca9 linter/no-duplicate-imports: Only check aggregated exports (#20178) (kennytm) - 691f556 linter/explicit-module-boundary-types: Ignore constructor callbacks (#20221) (camc314) ### ⚡ Performance - d160dca linter/plugins: Reduce array lookups in visitor compilation (#20249) (overlookmotel) ### 📚 Documentation - 0c7da4f linter: Fix extra closing brace in example config. (#20253) (connorshea) - 13606c3 linter/plugins: Update conformance README (#20234) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - 11a2b45 oxfmt: Skip `vite.config.ts` w/o `.fmt` field in auto-discovery (#20254) (leaysgur) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vite.config.tsmay return function fromdefineConfig(({ mode }) => ({ ... })), but we can't evaluate.Just skip it like no
.lint|fmtconfig.