fix(linter/no-duplicate-imports): only check aggregated exports#20178
Merged
camc314 merged 1 commit intooxc-project:mainfrom Mar 11, 2026
Merged
fix(linter/no-duplicate-imports): only check aggregated exports#20178camc314 merged 1 commit intooxc-project:mainfrom
camc314 merged 1 commit intooxc-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the eslint/no-duplicate-imports rule to match ESLint’s behavior when includeExports is enabled by avoiding false positives for export lists without a from clause (e.g., export { M, MC };) that re-export previously imported bindings.
Changes:
- Skip duplicate-export checks for
export { ... };/export type { ... };statements that do not have afromclause. - Add regression tests ensuring re-exporting imported bindings via export lists does not trigger
no-duplicate-importswhenincludeExports: true.
You can also share your feedback on Copilot code review. Take the survey.
camc314
changed the title
Merging this PR will not alter performance
Comparing 
Footnotes
|
leaysgur
added a commit
that referenced
this pull request
Mar 12, 2026
# Oxlint ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - cc89dbf oxlint: Skip `vite.config.ts` w/o `.lint` field in auto-discovery (#20255) (leaysgur) - 89b7ca9 linter/no-duplicate-imports: Only check aggregated exports (#20178) (kennytm) - 691f556 linter/explicit-module-boundary-types: Ignore constructor callbacks (#20221) (camc314) ### ⚡ Performance - d160dca linter/plugins: Reduce array lookups in visitor compilation (#20249) (overlookmotel) ### 📚 Documentation - 0c7da4f linter: Fix extra closing brace in example config. (#20253) (connorshea) - 13606c3 linter/plugins: Update conformance README (#20234) (overlookmotel) # Oxfmt ### 🐛 Bug Fixes - 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)` (#20260) (leaysgur) - 11a2b45 oxfmt: Skip `vite.config.ts` w/o `.fmt` field in auto-discovery (#20254) (leaysgur) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip checking
export { ... };in eslint/no-duplicate-imports when includeExports is enabled, matching ESLint behavior.close #20176.