Skip to content

docs(linter): Fix extra closing brace in example config.#20253

Merged
graphite-app[bot] merged 1 commit intomainfrom
rm-closing-brace
Mar 12, 2026
Merged

docs(linter): Fix extra closing brace in example config.#20253
graphite-app[bot] merged 1 commit intomainfrom
rm-closing-brace

Conversation

@connorshea
Copy link
Member

@connorshea connorshea commented Mar 12, 2026

This resulted in the example config in the docs being unformatted, as the code was invalid. Oops.

Screenshot 2026-03-11 at 7 10 01 PM

@connorshea connorshea requested a review from camc314 as a code owner March 12, 2026 01:09
Copilot AI review requested due to automatic review settings March 12, 2026 01:09
@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an extra closing brace from the oxlint.config.ts example in the Rustdoc for the linter configuration, restoring valid formatting for the documented config snippet.

Changes:

  • Fixes the oxlint.config.ts documentation example by removing an unintended extra } so the snippet formats correctly.

connorshea added a commit to oxc-project/website that referenced this pull request Mar 12, 2026
It was invalid and thus wasn't being formatted before.

Fixed in oxc with oxc-project/oxc#20253, but I think it's worth porting the fix here ahead of time.
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1


Comparing rm-closing-brace (4271fd1) with main (bee0b50)

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

connorshea added a commit to oxc-project/website that referenced this pull request Mar 12, 2026
It was invalid and thus wasn't being formatted before.

Fixed in oxc with oxc-project/oxc#20253, but I think it's worth porting the fix here ahead of time.
@connorshea connorshea added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
Copy link
Member Author

connorshea commented Mar 12, 2026

Merge activity

This resulted in the example config in the docs being unformatted, as the code was invalid. Oops.

<img width="574" height="695" alt="Screenshot 2026-03-11 at 7 10 01 PM" src="https://github.com/user-attachments/assets/febeae18-1c7d-47b3-8bee-2e95d541c655" />
@graphite-app graphite-app bot force-pushed the rm-closing-brace branch from 4271fd1 to 0c7da4f Compare March 12, 2026 01:49
@graphite-app graphite-app bot merged commit 0c7da4f into main Mar 12, 2026
21 checks passed
@graphite-app graphite-app bot deleted the rm-closing-brace branch March 12, 2026 02:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2026
leaysgur added a commit that referenced this pull request Mar 12, 2026
# Oxlint
### 🐛 Bug Fixes

- 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)`
(#20260) (leaysgur)
- cc89dbf oxlint: Skip `vite.config.ts` w/o `.lint` field in
auto-discovery (#20255) (leaysgur)
- 89b7ca9 linter/no-duplicate-imports: Only check aggregated exports
(#20178) (kennytm)
- 691f556 linter/explicit-module-boundary-types: Ignore constructor
callbacks (#20221) (camc314)

### ⚡ Performance

- d160dca linter/plugins: Reduce array lookups in visitor compilation
(#20249) (overlookmotel)

### 📚 Documentation

- 0c7da4f linter: Fix extra closing brace in example config. (#20253)
(connorshea)
- 13606c3 linter/plugins: Update conformance README (#20234)
(overlookmotel)
# Oxfmt
### 🐛 Bug Fixes

- 4ea67de oxlint,oxfmt: Skip `vite.config.ts` exports `defineConfig(fn)`
(#20260) (leaysgur)
- 11a2b45 oxfmt: Skip `vite.config.ts` w/o `.fmt` field in
auto-discovery (#20254) (leaysgur)

Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants