feat(parser): report error for using declarations in ambient contexts#19934
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript parsing diagnostics to explicitly report errors when using / await using declarations appear in ambient contexts (e.g., inside declare namespace / declare module), and refreshes coverage snapshots to reflect the new error codes/messages.
Changes:
- Emit TS-style diagnostics for
usingandawait usingdeclarations in ambient contexts (TS1545/TS1546). - Prevent the generic “initializers not allowed in ambient contexts” diagnostic from firing for
using-kind declarators (so the more specific diagnostic is reported instead). - Update TypeScript and Babel parser coverage snapshots to match the new diagnostics and pass counts.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tasks/coverage/snapshots/parser_typescript.snap | Updates TypeScript coverage snapshot outputs for the new ambient-context using diagnostics and expected results. |
| tasks/coverage/snapshots/parser_babel.snap | Updates Babel parser fixture snapshot outputs to use TS1545/TS1546 instead of TS1039 for these cases. |
| crates/oxc_parser/src/js/declaration.rs | Adds ambient-context validation for using/await using declarations and avoids overlapping ambient initializer diagnostics for using-kinds. |
| crates/oxc_parser/src/diagnostics.rs | Introduces new TS diagnostics (1545/1546) with messages matching updated snapshots. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
force-pushed
the
c/03-02-feat_parser_report_error_for_using_declarations_in_ambient_contexts
branch
from
7757257 to
38988ba
Compare
Merge activity
|
graphite-app
bot
force-pushed
the
c/03-02-feat_parser_report_error_for_using_declarations_in_ambient_contexts
branch
from
38988ba to
e8547cc
Compare
graphite-app
bot
deleted the
c/03-02-feat_parser_report_error_for_using_declarations_in_ambient_contexts
branch
### 🚀 Features - e8547cc parser: Report error for using declarations in ambient contexts (#19934) (camc314) - 8345318 allocator: Add methods for boxed slices `ArenaBox<[T]>` (#19968) (overlookmotel) - f83be30 allocator: Add `Vec::push_fast` method (#19959) (overlookmotel) ### 🐛 Bug Fixes - 291d867 transformer_plugins: Unwrap ChainExpression after define replacement removes optional markers (#20058) (IWANABETHATGUY) - 36b2e56 codegen: Print type for TSImportEqualsDeclaration (#20128) (camc314) - 5a246ec codegen: Print type arguments for JSXOpeningElement (#20127) (camc314) - a40870e codegen: Preserve parens for TSNonNullExpression (#20125) (camc314) - ae830b2 codegen: Print `declare` for `TSInterfaceDeclaration` (#20124) (camc314) - 92cfb14 linter/plugins: Fix types for `walkProgram` and `walkProgramWithCfg` (#20081) (overlookmotel) - ee0491e apps,napi: Explicitly specify libs in tsconfigs (#20071) (camc314) - 588009e codegen: Print `static` keyword for TSIndexSignature (#19755) (Dunqing) - 5a8799c codegen: Print `with_clause` for `ExportNamedDeclaration` (#20002) (Dunqing) - 7502afe parser: Correct capacity for tokens `Vec` (#19967) (overlookmotel) ### ⚡ Performance - 4ea8f9a napi: Remove `napi_build::setup()` from `oxc_napi` to avoid redundant rebuilds (#20094) (Boshen) - 2baa5fb napi: Unify build-test profile to coverage for cache sharing (#20090) (Boshen) - 8ba61dd parser: Make pushing tokens faster (#19960) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
No description provided.