Skip to content

fix(codegen): print static keyword for TSIndexSignature#19755

Draft
Dunqing wants to merge 1 commit intomainfrom
fix/codegen-static-index-signature
Draft

fix(codegen): print static keyword for TSIndexSignature#19755
Dunqing wants to merge 1 commit intomainfrom
fix/codegen-static-index-signature

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 26, 2026

The codegen was missing the static keyword when printing TSIndexSignature
nodes, causing static [key: string]: string index signatures to lose the
static modifier during code generation.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Feb 26, 2026
Copy link
Member Author

Dunqing commented Feb 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing fix/codegen-static-index-signature (8cad8f5) with main (ed17bbf)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot changed the base branch from fix/codegen-override-keyword to graphite-base/19755 February 26, 2026 13:43
@graphite-app graphite-app bot force-pushed the graphite-base/19755 branch from bf4a1ae to ed17bbf Compare February 26, 2026 13:51
@graphite-app graphite-app bot force-pushed the fix/codegen-static-index-signature branch from 1bb492f to b7233d9 Compare February 26, 2026 13:51
@graphite-app graphite-app bot changed the base branch from graphite-base/19755 to main February 26, 2026 13:52
The codegen was missing the `static` keyword when printing `TSIndexSignature`
nodes, causing `static [key: string]: string` index signatures to lose the
`static` modifier during code generation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@graphite-app graphite-app bot force-pushed the fix/codegen-static-index-signature branch from b7233d9 to 8cad8f5 Compare February 26, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant