Skip to content

docs(linter): Improve docs for eslint/radix rule.#19611

Merged
graphite-app[bot] merged 1 commit intomainfrom
better-radix-docs
Feb 21, 2026
Merged

docs(linter): Improve docs for eslint/radix rule.#19611
graphite-app[bot] merged 1 commit intomainfrom
better-radix-docs

Conversation

@connorshea
Copy link
Member

To explain the change that occurred, and make it clearer for users that run into this problem.

Copilot AI review requested due to automatic review settings February 21, 2026 18:22
@connorshea connorshea requested a review from camc314 as a code owner February 21, 2026 18:22
@github-actions github-actions bot added A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation labels Feb 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the documentation for the eslint/radix linter rule to better explain a breaking change introduced in v1.49.0 and provide clearer guidance to users.

Changes:

  • Added a new "Configuration" section explaining that the config option was removed in v1.49.0 and is now a no-op, matching ESLint v10 behavior
  • Enhanced help messages to clarify that users can specify any appropriate radix, not just 10
  • Fixed grammar issues in code comments ("affect" → "effect", improved phrasing)
  • Modernized code examples (changed var to let)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/rules/eslint/radix.rs Updated rule documentation with new Configuration section, improved help messages, fixed grammar in comments, and modernized examples
crates/oxc_linter/src/snapshots/eslint_radix.snap Updated snapshot to reflect the improved help message text for missing radix parameter diagnostics

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing better-radix-docs (0671901) with main (79fe3b4)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026
Copy link
Contributor

camc314 commented Feb 21, 2026

Merge activity

To explain the change that occurred, and make it clearer for users that run into this problem.
@graphite-app graphite-app bot merged commit a331993 into main Feb 21, 2026
21 checks passed
@graphite-app graphite-app bot deleted the better-radix-docs branch February 21, 2026 18:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026
camc314 pushed a commit that referenced this pull request Feb 23, 2026
# Oxlint
### 🚀 Features

- 46177dd linter: Implement unicorn/prefer-module (#19603) (camc314)
- 42f78bb linter: Implement unicorn/prefer-ternary (#19605) (camc314)

### 🐛 Bug Fixes

- 43df857 react/exhaustive-deps: Normalize .current callback deps
(#19610) (camc314)
- 574f48f linter/no-throw-literal: Close warning block (#19612)
(camc314)
- 79fe3b4 linter/prefer-mock-return-shorthand: Avoid unsafe autofixes
for call-like returns (#19581) (camc314)
- 85045e8 linter: Check protected members in
explicit-module-boundary-types (#19594) (camc314)
- e38115e linter: Catch missing return type on exported arrow/function
expressions (#19587) (Peter Wagenet)
- 419d3fd linter: Fix false negatives in typescript/no-require-imports
(#19589) (Peter Wagenet)
- 7958b56 linter: Fix syntax error reporting in some output formatters.
(#19590) (connorshea)
- 024f51c linter: Add help text to more eslint diagnostics (#19591)
(Anthony Amaro)
- a8489a1 linter: Warning `eslint/no-throw-literal` rule to be
deprecated, better use `typescript/only-throw-error` (#19593) (Said
Atrahouch)
- 50fc70d linter/type-aware: Use correct span for disable directives
(#19576) (camc314)
- 421a99c linter: Add help guidance to eslint diagnostic messages
(#19562) (Anthony Amaro)
- e81364a linter: Add help text to eslint rule diagnostics (#19560)
(Anthony Amaro)
- 89b58d0 linter: Add help text to more eslint rule diagnostics (#19561)
(Anthony Amaro)
- 74f7833 linter/jest/prefer-mock-return-shorthand: Preserve typed arrow
returns (#19556) (camc314)
- bdd6f34 linter: Restrict prefer-import-in-mock to mock calls (#19555)
(camc314)

### 📚 Documentation

- a331993 linter: Improve docs for `eslint/radix` rule. (#19611)
(connorshea)

### 🛡️ Security

- c67f9dc linter: Update ajv version. (#19613) (connorshea)
# Oxfmt
### 🚀 Features

- 984dc07 oxfmt: Strip `"experimental"SortXxx` prefix (#19567)
(leaysgur)

### 🐛 Bug Fixes

- d7b63a4 oxfmt: Update API types for `sortPackageJsonOptions` (#19569)
(leaysgur)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants