feat(linter): implement unicorn/prefer-ternary by camc314 · Pull Request #19605 · oxc-project/oxc

camc314 · 2026-02-21T13:43:07Z

No description provided.

camc314 · 2026-02-21T13:43:17Z

feat(linter): implement unicorn/prefer-ternary #19605 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-21T13:54:01Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-10-feat_linter_implement_unicorn_prefer-ternary (ba3a708) with main (79fe3b4)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

crates/oxc_linter/src/rules/unicorn/prefer_ternary.rs

Copilot

Pull request overview

This pull request implements the unicorn/prefer-ternary linter rule, which suggests using ternary expressions instead of simple if-else statements for improved code conciseness and readability. The rule supports two configuration modes: "always" (default) and "only-single-line".

Changes:

Added new rule implementation in prefer_ternary.rs with comprehensive logic for detecting mergeable if-else patterns
Added extensive test coverage with 50+ passing cases and 50+ failing cases
Updated all generated/integration files to register the new rule

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/unicorn/prefer_ternary.rs	Core rule implementation with mergeability checking logic, configuration handling, and comprehensive tests
crates/oxc_linter/src/snapshots/unicorn_prefer_ternary.snap	Test snapshot file containing expected diagnostic outputs for 50+ test cases
crates/oxc_linter/src/rules.rs	Added module declaration for the new rule
crates/oxc_linter/src/generated/rules_enum.rs	Auto-generated enum registration and trait implementations for the rule
crates/oxc_linter/src/generated/rule_runner_impls.rs	Auto-generated runner implementation specifying the rule runs on IfStatement nodes

camc314 · 2026-02-21T21:38:41Z

Merge activity

Feb 21, 9:38 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 21, 9:38 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 21, 9:48 PM UTC: Merged by the Graphite merge queue.

# Oxlint ### 🚀 Features - 46177dd linter: Implement unicorn/prefer-module (#19603) (camc314) - 42f78bb linter: Implement unicorn/prefer-ternary (#19605) (camc314) ### 🐛 Bug Fixes - 43df857 react/exhaustive-deps: Normalize .current callback deps (#19610) (camc314) - 574f48f linter/no-throw-literal: Close warning block (#19612) (camc314) - 79fe3b4 linter/prefer-mock-return-shorthand: Avoid unsafe autofixes for call-like returns (#19581) (camc314) - 85045e8 linter: Check protected members in explicit-module-boundary-types (#19594) (camc314) - e38115e linter: Catch missing return type on exported arrow/function expressions (#19587) (Peter Wagenet) - 419d3fd linter: Fix false negatives in typescript/no-require-imports (#19589) (Peter Wagenet) - 7958b56 linter: Fix syntax error reporting in some output formatters. (#19590) (connorshea) - 024f51c linter: Add help text to more eslint diagnostics (#19591) (Anthony Amaro) - a8489a1 linter: Warning `eslint/no-throw-literal` rule to be deprecated, better use `typescript/only-throw-error` (#19593) (Said Atrahouch) - 50fc70d linter/type-aware: Use correct span for disable directives (#19576) (camc314) - 421a99c linter: Add help guidance to eslint diagnostic messages (#19562) (Anthony Amaro) - e81364a linter: Add help text to eslint rule diagnostics (#19560) (Anthony Amaro) - 89b58d0 linter: Add help text to more eslint rule diagnostics (#19561) (Anthony Amaro) - 74f7833 linter/jest/prefer-mock-return-shorthand: Preserve typed arrow returns (#19556) (camc314) - bdd6f34 linter: Restrict prefer-import-in-mock to mock calls (#19555) (camc314) ### 📚 Documentation - a331993 linter: Improve docs for `eslint/radix` rule. (#19611) (connorshea) ### 🛡️ Security - c67f9dc linter: Update ajv version. (#19613) (connorshea) # Oxfmt ### 🚀 Features - 984dc07 oxfmt: Strip `"experimental"SortXxx` prefix (#19567) (leaysgur) ### 🐛 Bug Fixes - d7b63a4 oxfmt: Update API types for `sortPackageJsonOptions` (#19569) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 21, 2026

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-switch branch from 1d74766 to 8bad22c Compare February 21, 2026 13:53

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from f7a4c6d to a0cbd0d Compare February 21, 2026 13:53

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from 57788eb to de4ac82 Compare February 21, 2026 16:29

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-switch branch from 8e140bf to 96a2135 Compare February 21, 2026 16:37

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from 6578ec8 to 0b09ea3 Compare February 21, 2026 16:37

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-switch branch from 96a2135 to efd8c0f Compare February 21, 2026 17:30

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from 0b09ea3 to 090832c Compare February 21, 2026 17:30

connorshea reviewed Feb 21, 2026

View reviewed changes

crates/oxc_linter/src/rules/unicorn/prefer_ternary.rs Show resolved Hide resolved

connorshea reviewed Feb 21, 2026

View reviewed changes

crates/oxc_linter/src/rules/unicorn/prefer_ternary.rs Outdated Show resolved Hide resolved

camc314 changed the base branch from c/02-10-feat_linter_implement_unicorn_prefer-switch to graphite-base/19605 February 21, 2026 18:06

camc314 force-pushed the graphite-base/19605 branch from efd8c0f to 79fe3b4 Compare February 21, 2026 18:06

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from 090832c to cf7c921 Compare February 21, 2026 18:06

camc314 changed the base branch from graphite-base/19605 to main February 21, 2026 18:06

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from cf7c921 to 4eb6ee4 Compare February 21, 2026 18:07

camc314 self-assigned this Feb 21, 2026

camc314 marked this pull request as ready for review February 21, 2026 18:08

Copilot AI review requested due to automatic review settings February 21, 2026 18:08

Copilot started reviewing on behalf of camc314 February 21, 2026 18:09 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from 4eb6ee4 to ba3a708 Compare February 21, 2026 18:18

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026

feat(linter): implement unicorn/prefer-ternary (#19605)

42f78bb

graphite-app bot force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch from ba3a708 to 42f78bb Compare February 21, 2026 21:42

graphite-app bot merged commit 42f78bb into main Feb 21, 2026
21 checks passed

graphite-app bot deleted the c/02-10-feat_linter_implement_unicorn_prefer-ternary branch February 21, 2026 21:48

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026

Boshen mentioned this pull request Feb 23, 2026

release(apps): oxlint v1.50.0 && oxfmt v0.35.0 #19627

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): implement unicorn/prefer-ternary#19605

feat(linter): implement unicorn/prefer-ternary#19605
graphite-app[bot] merged 1 commit intomainfrom
c/02-10-feat_linter_implement_unicorn_prefer-ternary

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

camc314 commented Feb 21, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

camc314 commented Feb 21, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Feb 21, 2026 •

edited

Loading

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

camc314 commented Feb 21, 2026 •

edited by graphite-app bot

Loading