feat(linter): implement unicorn/prefer-module by camc314 · Pull Request #19603 · oxc-project/oxc

camc314 · 2026-02-21T13:43:04Z

No description provided.

camc314 · 2026-02-21T13:43:14Z

feat(linter): implement unicorn/prefer-switch #19604
feat(linter): implement unicorn/prefer-module #19603 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-21T13:51:43Z

Merging this PR will not alter performance

✅ 43 untouched benchmarks
⏩ 7 skipped benchmarks¹

_{Comparing c/02-10-feat_linter_implement_unicorn_prefer-module (d9461a6) with main (42f78bb)}

7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull request overview

Implements the eslint-plugin-unicorn(prefer-module) lint rule in oxc_linter, adding diagnostics to discourage CommonJS globals / patterns (and related strict-mode artifacts) to encourage ES module usage.

Changes:

Added a new unicorn/prefer-module rule that reports on "use strict" directives, top-level return, and CommonJS globals (require, module, exports, __filename, __dirname) when referenced as globals.
Added rule tests and a corresponding snapshot.
Registered the new rule in the unicorn module list and generated rule enum/runner plumbing.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`crates/oxc_linter/src/rules/unicorn/prefer_module.rs`	New rule implementation + test cases for expected pass/fail behavior.
`crates/oxc_linter/src/snapshots/unicorn_prefer_module.snap`	Snapshot output for the new rule’s test suite.
`crates/oxc_linter/src/rules.rs`	Exposes the new rule module under `unicorn`.
`crates/oxc_linter/src/generated/rules_enum.rs`	Registers the rule in the generated enum and metadata dispatch.
`crates/oxc_linter/src/generated/rule_runner_impls.rs`	Adds the rule’s AST node type registration for runner dispatch.

crates/oxc_linter/src/rules/unicorn/prefer_module.rs

camc314 · 2026-02-21T21:51:46Z

Merge activity

Feb 21, 9:51 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 21, 9:56 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 21, 10:02 PM UTC: Merged by the Graphite merge queue.

# Oxlint ### 🚀 Features - 46177dd linter: Implement unicorn/prefer-module (#19603) (camc314) - 42f78bb linter: Implement unicorn/prefer-ternary (#19605) (camc314) ### 🐛 Bug Fixes - 43df857 react/exhaustive-deps: Normalize .current callback deps (#19610) (camc314) - 574f48f linter/no-throw-literal: Close warning block (#19612) (camc314) - 79fe3b4 linter/prefer-mock-return-shorthand: Avoid unsafe autofixes for call-like returns (#19581) (camc314) - 85045e8 linter: Check protected members in explicit-module-boundary-types (#19594) (camc314) - e38115e linter: Catch missing return type on exported arrow/function expressions (#19587) (Peter Wagenet) - 419d3fd linter: Fix false negatives in typescript/no-require-imports (#19589) (Peter Wagenet) - 7958b56 linter: Fix syntax error reporting in some output formatters. (#19590) (connorshea) - 024f51c linter: Add help text to more eslint diagnostics (#19591) (Anthony Amaro) - a8489a1 linter: Warning `eslint/no-throw-literal` rule to be deprecated, better use `typescript/only-throw-error` (#19593) (Said Atrahouch) - 50fc70d linter/type-aware: Use correct span for disable directives (#19576) (camc314) - 421a99c linter: Add help guidance to eslint diagnostic messages (#19562) (Anthony Amaro) - e81364a linter: Add help text to eslint rule diagnostics (#19560) (Anthony Amaro) - 89b58d0 linter: Add help text to more eslint rule diagnostics (#19561) (Anthony Amaro) - 74f7833 linter/jest/prefer-mock-return-shorthand: Preserve typed arrow returns (#19556) (camc314) - bdd6f34 linter: Restrict prefer-import-in-mock to mock calls (#19555) (camc314) ### 📚 Documentation - a331993 linter: Improve docs for `eslint/radix` rule. (#19611) (connorshea) ### 🛡️ Security - c67f9dc linter: Update ajv version. (#19613) (connorshea) # Oxfmt ### 🚀 Features - 984dc07 oxfmt: Strip `"experimental"SortXxx` prefix (#19567) (leaysgur) ### 🐛 Bug Fixes - d7b63a4 oxfmt: Update API types for `sortPackageJsonOptions` (#19569) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

This was referenced Feb 21, 2026

feat(linter): implement unicorn/prefer-export-from #19602

Draft

feat(linter): implement unicorn/prefer-switch #19604

Draft

feat(linter): implement unicorn/prefer-ternary #19605

Merged

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 21, 2026

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from 40d71ff to 57ce894 Compare February 21, 2026 13:53

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-export-from branch from 755e69a to 038a28d Compare February 21, 2026 13:53

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from 57ce894 to a52d51a Compare February 21, 2026 16:29

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-export-from branch from 038a28d to 15a969f Compare February 21, 2026 16:29

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from a315cd5 to 4350365 Compare February 21, 2026 16:37

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-export-from branch 2 times, most recently from 9136296 to c0562c7 Compare February 21, 2026 17:30

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from 4350365 to 52f4221 Compare February 21, 2026 17:30

camc314 self-assigned this Feb 21, 2026

camc314 marked this pull request as ready for review February 21, 2026 21:40

Copilot AI review requested due to automatic review settings February 21, 2026 21:40

camc314 changed the base branch from c/02-10-feat_linter_implement_unicorn_prefer-export-from to graphite-base/19603 February 21, 2026 21:40

camc314 force-pushed the graphite-base/19603 branch from c0562c7 to 79fe3b4 Compare February 21, 2026 21:40

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from 52f4221 to 4ff8936 Compare February 21, 2026 21:40

camc314 changed the base branch from graphite-base/19603 to main February 21, 2026 21:40

Copilot started reviewing on behalf of camc314 February 21, 2026 21:40 View session

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from 4ff8936 to c9f1e32 Compare February 21, 2026 21:42

Copilot AI reviewed Feb 21, 2026

View reviewed changes

camc314 force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from c9f1e32 to d9461a6 Compare February 21, 2026 21:51

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026

feat(linter): implement unicorn/prefer-module (#19603)

46177dd

graphite-app bot force-pushed the c/02-10-feat_linter_implement_unicorn_prefer-module branch from d9461a6 to 46177dd Compare February 21, 2026 21:56

graphite-app bot merged commit 46177dd into main Feb 21, 2026
21 checks passed

graphite-app bot deleted the c/02-10-feat_linter_implement_unicorn_prefer-module branch February 21, 2026 22:02

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 21, 2026

Boshen mentioned this pull request Feb 23, 2026

release(apps): oxlint v1.50.0 && oxfmt v0.35.0 #19627

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): implement unicorn/prefer-module#19603

feat(linter): implement unicorn/prefer-module#19603
graphite-app[bot] merged 1 commit intomainfrom
c/02-10-feat_linter_implement_unicorn_prefer-module

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 21, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Feb 21, 2026

Uh oh!

camc314 commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camc314 commented Feb 21, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Feb 21, 2026 •

edited

Loading

codspeed-hq bot commented Feb 21, 2026 •

edited

Loading

camc314 commented Feb 21, 2026 •

edited by graphite-app bot

Loading