feat(linter): add typescript/consistent-return rule by camc314 · Pull Request #19449 · oxc-project/oxc

camc314 · 2026-02-16T17:16:20Z

No description provided.

camc314 · 2026-02-16T17:16:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-16T17:27:58Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-14-feat_linter_add_typescript_consistent-return_rule (7dd13b8) with c/02-14-feat_linter_add_typescript_prefer-string-starts-ends-with_rule (1a528ed)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camc314 · 2026-02-16T19:26:30Z

Merge activity

Feb 16, 7:26 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 16, 7:50 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Feb 16, 8:09 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 16, 8:16 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

Adds the TypeScript consistent-return rule (type-aware via tsgolint) to the linter’s rule set and wires it through the generated rule registry and oxlint fixtures/snapshots.

Changes:

Introduces typescript/consistent-return rule metadata + configuration schema/serde handling.
Registers the rule in the TypeScript rules module and generated RuleEnum/runner glue.
Adds fixture coverage and updates snapshots/configs to exercise the new rule (including treatUndefinedAsUnspecified).

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/typescript/consistent_return.rs	New rule wrapper + config schema/docs for `consistent-return`
crates/oxc_linter/src/rules.rs	Exposes the new TypeScript rule module
crates/oxc_linter/src/generated/rules_enum.rs	Registers the new rule in the generated rule enum/metadata wiring
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds generated runner metadata for the new rule
apps/oxlint/fixtures/tsgolint/consistent-return.ts	Adds a fixture that triggers the rule
apps/oxlint/fixtures/tsgolint/.oxlintrc.json	Enables the rule in the tsgolint fixture set
apps/oxlint/fixtures/tsgolint_rule_options/test.ts	Adds an options fixture for `treatUndefinedAsUnspecified`
apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json	Enables the rule with options in the options fixture set
apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware@oxlint.snap	Updates expected output for the new rule in type-aware run
apps/oxlint/src/snapshots/fixtures__tsgolint_rule_options_--type-aware@oxlint.snap	Updates expected output for rule-options fixture run

crates/oxc_linter/src/rules/typescript/consistent_return.rs

apps/oxlint/fixtures/tsgolint_rule_options/test.ts

# Oxlint ### 💥 BREAKING CHANGES - 4315594 oxlint: [**BREAKING**] Deprecate `"always"` and `"as-needed"` options of the radix rule (#19408) (Sysix) - d4c7af3 linter: [**BREAKING**] Remove `allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing` option (#19451) (camc314) ### 🚀 Features - 82ca5c3 linter: Add typescript/dot-notation rule (#19442) (camc314) - 6db0811 linter: Implement eslint-plugin-vitest/no-importing-vitest-globals (#18694) (Said Atrahouch) - c7fe8ae linter: Implement eslint-plugin-vitest/prefer-import-in-mock (#17966) (Said Atrahouch) - 0abb39a linter: Implement eslint-vitest-jest-plugin/prefer-mock-return-shorthand (#18002) (Said Atrahouch) - 2b95537 linter: Implement `n/no-path-concat` rule (#19502) (Mikhail Baev) - 735d0e4 linter: Implement typescript/no-useless-default-assignment (#19488) (camc314) - 31c3a93 linter: Add typescript/no-unnecessary-type-parameters rule (#19450) (camc314) - c948090 linter: Add typescript/consistent-return rule (#19449) (camc314) - 9f87df0 linter: Add typescript/prefer-string-starts-ends-with rule (#19448) (camc314) - 04536be linter: Add typescript/prefer-regexp-exec rule (#19447) (camc314) - 56a7feb linter: Add typescript/prefer-readonly rule (#19446) (camc314) - a1cea63 linter: Add typescript/no-unnecessary-qualifier rule (#19445) (camc314) - e3144d2 linter: Add typescript/prefer-find rule (#19444) (camc314) - 13c7408 linter: Add typescript/prefer-readonly-parameter-types rule (#19443) (camc314) - 9b17d44 linter: Add typescript/strict-void-return rule (#19441) (camc314) - ed821b4 linter: Add typescript/consistent-type-exports rule (#19440) (camc314) ### 🐛 Bug Fixes - daad7bc linter/array-callback-return: Check `allowVoid` option (#19506) (Said Atrahouch) - 638cf94 linter: Add help text to eslint rule diagnostics (#19508) (Kyle Tse) - 79fc6d7 linter: Move no-use-before-define to eslint plugin (#19438) (camc314) - c832a9f linter: Add `onScrollEnd` and `onScrollEndCapture` to `react/no-unknown-property`. (#19536) (connorshea) - 999a0db linter: Add help text to `symbol-description` diagnostics (#19538) (Anthony Amaro) - f064482 linter: Add help text to eslint rule diagnostics (#19539) (Anthony Amaro) - fd11073 linter/react/no-unknown-property: Add missing `fetchPriority` prop (#19525) (João Pedro Schmitz) - a9bb604 linter/no-shadow: Align initializer shadow handling with typescript-eslint (#19462) (camc314) - 32e6eb9 linter: Handle typed arrays/array buffers in `prefer-spread` rule. (#19478) (connorshea) - e309f84 linter: Handle additional cases in `typescript/consistent-generic-constructors` rule. (#19477) (connorshea) - 71db91a linter/array-callback-return: Check `fromAsync`, update test cases (#19483) (Said Atrahouch) - 2a12d74 linter: Handle optional chaining in `no-array-method-this-argument` rule. (#19476) (connorshea) - f65310b linter: Handle optional chaining in `prefer-object-from-entries` rule. (#19475) (connorshea) - 840acf4 linter: Handle optional chain in `no-unnecessary-array-flat-depth` rule. (#19471) (connorshea) - 85a19e9 linter: Skip string literal imports in `consistent-assert` rule. (#19474) (connorshea) ### ⚡ Performance - 6155ac4 linter/constructor-super: Use node_id over nodes loop (#19489) (camc314) - a02496d linter/consistent-index-object-style: Resolve circular type refs semantically (#19490) (camc314) # Oxfmt ### 🚀 Features - 652c346 oxfmt/lsp: Support `untitled://` schema (#19287) (Sysix) ### 🐛 Bug Fixes - 6c61b70 oxfmt: Fix outdated `sortImports.groups` doc comments (#19513) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

This was referenced Feb 16, 2026

feat(linter): add typescript/prefer-regexp-exec rule #19447

Merged

feat(linter): add typescript/prefer-string-starts-ends-with rule #19448

Merged

feat(linter): add typescript/no-unnecessary-type-parameters rule #19450

Merged

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Feb 16, 2026

camc314 self-assigned this Feb 16, 2026

camc314 force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch from 7dd13b8 to 80631f1 Compare February 16, 2026 19:19

camc314 force-pushed the c/02-14-feat_linter_add_typescript_prefer-string-starts-ends-with_rule branch 2 times, most recently from 2256ba3 to f9b44a0 Compare February 16, 2026 19:21

camc314 force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch 3 times, most recently from f8c2f04 to 6f652d5 Compare February 16, 2026 19:26

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026

camc314 marked this pull request as ready for review February 16, 2026 19:26

Copilot AI review requested due to automatic review settings February 16, 2026 19:26

Copilot started reviewing on behalf of camc314 February 16, 2026 19:27 View session

camc314 force-pushed the c/02-14-feat_linter_add_typescript_prefer-string-starts-ends-with_rule branch from 2c9c1ac to 660f6f5 Compare February 16, 2026 19:30

camc314 force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch from 6f652d5 to 780d135 Compare February 16, 2026 19:30

Copilot AI reviewed Feb 16, 2026

View reviewed changes

crates/oxc_linter/src/rules/typescript/consistent_return.rs Show resolved Hide resolved

apps/oxlint/fixtures/tsgolint_rule_options/test.ts Show resolved Hide resolved

graphite-app bot changed the base branch from c/02-14-feat_linter_add_typescript_prefer-string-starts-ends-with_rule to graphite-base/19449 February 16, 2026 19:39

camc314 force-pushed the graphite-base/19449 branch from 660f6f5 to 9f87df0 Compare February 16, 2026 19:49

camc314 force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch from 780d135 to 9a2bea6 Compare February 16, 2026 19:49

graphite-app bot changed the base branch from graphite-base/19449 to main February 16, 2026 19:49

camc314 force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch 2 times, most recently from 1907da6 to b8f7584 Compare February 16, 2026 20:03

feat(linter): add typescript/consistent-return rule (#19449)

c948090

graphite-app bot force-pushed the c/02-14-feat_linter_add_typescript_consistent-return_rule branch from b8f7584 to c948090 Compare February 16, 2026 20:09

graphite-app bot merged commit c948090 into main Feb 16, 2026
21 checks passed

graphite-app bot deleted the c/02-14-feat_linter_add_typescript_consistent-return_rule branch February 16, 2026 20:16

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 16, 2026

Boshen mentioned this pull request Feb 19, 2026

release(apps): oxlint v1.49.0 && oxfmt v0.34.0 #19553

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): add typescript/consistent-return rule#19449

feat(linter): add typescript/consistent-return rule#19449
graphite-app[bot] merged 1 commit intomainfrom
c/02-14-feat_linter_add_typescript_consistent-return_rule

camc314 commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 16, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

camc314 commented Feb 16, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Feb 16, 2026 •

edited

Loading

camc314 commented Feb 16, 2026 •

edited by graphite-app bot

Loading