feat(linter): add typescript/dot-notation rule by camc314 · Pull Request #19442 · oxc-project/oxc

camc314 · 2026-02-16T17:15:01Z

No description provided.

camc314 · 2026-02-16T17:15:13Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-16T17:21:15Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-14-feat_linter_add_typescript_dot-notation_rule (0606b28) with main (933ff72)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

connorshea · 2026-02-16T18:57:09Z

@camc314 I think this will result in the same problem as we have with #19437, won't it?

camc314 · 2026-02-16T18:58:06Z

ugh you're right

let me move this out of the stack and address this later

connorshea · 2026-02-16T18:58:13Z

Actually, this rule isn't listed in the const for the eslint-extended typescript rules, so it shouldn't be a problem here. (though, it probably should be)

connorshea · 2026-02-16T22:56:37Z

Also, no-useless-default-assignment wasn't added to oxlint yet, was that intentional? https://github.com/oxc-project/tsgolint/tree/main/internal/rules/no_useless_default_assignment

camc314 · 2026-02-19T17:06:17Z

Also, no-useless-default-assignment wasn't added to oxlint yet, was that intentional? https://github.com/oxc-project/tsgolint/tree/main/internal/rules/no_useless_default_assignment

nope - added in #191488

camc314 · 2026-02-19T17:08:05Z

Merge activity

Feb 19, 5:08 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 19, 5:26 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 19, 5:33 PM UTC: Merged by the Graphite merge queue.

Copilot

Pull request overview

This PR adds the TypeScript dot-notation rule as a type-aware (tsgolint) lint, wiring it into the linter’s rule registry and updating fixtures/snapshots to reflect the new diagnostic.

Changes:

Added a new typescript/dot-notation rule definition with JSON-serializable configuration.
Registered the rule in the TypeScript rules module and generated rule enum/runner glue.
Updated type-aware fixture configs and snapshots to include the new rule and its expected output.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_linter/src/rules/typescript/dot_notation.rs	Introduces the rule stub + config serialization for the type-aware linter.
crates/oxc_linter/src/rules.rs	Exposes the new TypeScript rule module.
crates/oxc_linter/src/generated/rules_enum.rs	Registers the rule in the generated enum and metadata plumbing.
crates/oxc_linter/src/generated/rule_runner_impls.rs	Adds generated `RuleRunner` impl entry for the new rule.
apps/oxlint/src/snapshots/fixtures__tsgolint_rule_options_--type-aware@oxlint.snap	Updates snapshot output for the rule-options fixture run.
apps/oxlint/src/snapshots/fixtures__tsgolint_--type-aware@oxlint.snap	Updates snapshot output for the base tsgolint fixture run.
apps/oxlint/fixtures/tsgolint_rule_options/test.ts	Adds fixture code intended to exercise dot-notation options.
apps/oxlint/fixtures/tsgolint_rule_options/.oxlintrc.json	Enables dot-notation with options in the rule-options fixture config.
apps/oxlint/fixtures/tsgolint/dot-notation.ts	Adds a basic dot-notation failing example fixture.
apps/oxlint/fixtures/tsgolint/.oxlintrc.json	Enables dot-notation in the base tsgolint fixture config.

apps/oxlint/fixtures/tsgolint_rule_options/test.ts

# Oxlint ### 💥 BREAKING CHANGES - 4315594 oxlint: [**BREAKING**] Deprecate `"always"` and `"as-needed"` options of the radix rule (#19408) (Sysix) - d4c7af3 linter: [**BREAKING**] Remove `allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing` option (#19451) (camc314) ### 🚀 Features - 82ca5c3 linter: Add typescript/dot-notation rule (#19442) (camc314) - 6db0811 linter: Implement eslint-plugin-vitest/no-importing-vitest-globals (#18694) (Said Atrahouch) - c7fe8ae linter: Implement eslint-plugin-vitest/prefer-import-in-mock (#17966) (Said Atrahouch) - 0abb39a linter: Implement eslint-vitest-jest-plugin/prefer-mock-return-shorthand (#18002) (Said Atrahouch) - 2b95537 linter: Implement `n/no-path-concat` rule (#19502) (Mikhail Baev) - 735d0e4 linter: Implement typescript/no-useless-default-assignment (#19488) (camc314) - 31c3a93 linter: Add typescript/no-unnecessary-type-parameters rule (#19450) (camc314) - c948090 linter: Add typescript/consistent-return rule (#19449) (camc314) - 9f87df0 linter: Add typescript/prefer-string-starts-ends-with rule (#19448) (camc314) - 04536be linter: Add typescript/prefer-regexp-exec rule (#19447) (camc314) - 56a7feb linter: Add typescript/prefer-readonly rule (#19446) (camc314) - a1cea63 linter: Add typescript/no-unnecessary-qualifier rule (#19445) (camc314) - e3144d2 linter: Add typescript/prefer-find rule (#19444) (camc314) - 13c7408 linter: Add typescript/prefer-readonly-parameter-types rule (#19443) (camc314) - 9b17d44 linter: Add typescript/strict-void-return rule (#19441) (camc314) - ed821b4 linter: Add typescript/consistent-type-exports rule (#19440) (camc314) ### 🐛 Bug Fixes - daad7bc linter/array-callback-return: Check `allowVoid` option (#19506) (Said Atrahouch) - 638cf94 linter: Add help text to eslint rule diagnostics (#19508) (Kyle Tse) - 79fc6d7 linter: Move no-use-before-define to eslint plugin (#19438) (camc314) - c832a9f linter: Add `onScrollEnd` and `onScrollEndCapture` to `react/no-unknown-property`. (#19536) (connorshea) - 999a0db linter: Add help text to `symbol-description` diagnostics (#19538) (Anthony Amaro) - f064482 linter: Add help text to eslint rule diagnostics (#19539) (Anthony Amaro) - fd11073 linter/react/no-unknown-property: Add missing `fetchPriority` prop (#19525) (João Pedro Schmitz) - a9bb604 linter/no-shadow: Align initializer shadow handling with typescript-eslint (#19462) (camc314) - 32e6eb9 linter: Handle typed arrays/array buffers in `prefer-spread` rule. (#19478) (connorshea) - e309f84 linter: Handle additional cases in `typescript/consistent-generic-constructors` rule. (#19477) (connorshea) - 71db91a linter/array-callback-return: Check `fromAsync`, update test cases (#19483) (Said Atrahouch) - 2a12d74 linter: Handle optional chaining in `no-array-method-this-argument` rule. (#19476) (connorshea) - f65310b linter: Handle optional chaining in `prefer-object-from-entries` rule. (#19475) (connorshea) - 840acf4 linter: Handle optional chain in `no-unnecessary-array-flat-depth` rule. (#19471) (connorshea) - 85a19e9 linter: Skip string literal imports in `consistent-assert` rule. (#19474) (connorshea) ### ⚡ Performance - 6155ac4 linter/constructor-super: Use node_id over nodes loop (#19489) (camc314) - a02496d linter/consistent-index-object-style: Resolve circular type refs semantically (#19490) (camc314) # Oxfmt ### 🚀 Features - 652c346 oxfmt/lsp: Support `untitled://` schema (#19287) (Sysix) ### 🐛 Bug Fixes - 6c61b70 oxfmt: Fix outdated `sortImports.groups` doc comments (#19513) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 mentioned this pull request Feb 16, 2026

feat(linter): add typescript/consistent-type-exports rule #19440

Merged

This was referenced Feb 16, 2026

feat(linter): add typescript/strict-void-return rule #19441

Merged

feat(linter): add typescript/prefer-readonly-parameter-types rule #19443

Merged

feat(linter): add typescript/prefer-find rule #19444

Merged

github-actions bot added A-linter Area - Linter A-cli Area - CLI C-enhancement Category - New feature or request labels Feb 16, 2026

camc314 force-pushed the c/02-14-feat_linter_add_typescript_strict-void-return_rule branch from 7be1f6a to bb4f5f1 Compare February 16, 2026 18:42

camc314 force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from fc9cabc to 2b75ed4 Compare February 16, 2026 18:44

camc314 self-assigned this Feb 16, 2026

graphite-app bot changed the base branch from c/02-14-feat_linter_add_typescript_strict-void-return_rule to graphite-base/19442 February 16, 2026 19:00

camc314 force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from 2b75ed4 to f812e18 Compare February 16, 2026 20:08

camc314 force-pushed the graphite-base/19442 branch from bb4f5f1 to a16f25e Compare February 16, 2026 20:08

camc314 changed the base branch from graphite-base/19442 to c/02-14-feat_linter_add_typescript_no-unnecessary-type-parameters_rule February 16, 2026 20:08

graphite-app bot changed the base branch from c/02-14-feat_linter_add_typescript_no-unnecessary-type-parameters_rule to graphite-base/19442 February 16, 2026 20:10

graphite-app bot force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from f812e18 to ceb5c86 Compare February 16, 2026 20:18

graphite-app bot force-pushed the graphite-base/19442 branch from a16f25e to 31c3a93 Compare February 16, 2026 20:18

graphite-app bot changed the base branch from graphite-base/19442 to main February 16, 2026 20:19

graphite-app bot force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from ceb5c86 to 26be8f7 Compare February 16, 2026 20:19

camc314 force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from 26be8f7 to 0606b28 Compare February 19, 2026 17:06

camc314 marked this pull request as ready for review February 19, 2026 17:07

Copilot AI review requested due to automatic review settings February 19, 2026 17:07

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 19, 2026

Copilot started reviewing on behalf of camc314 February 19, 2026 17:08 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

apps/oxlint/fixtures/tsgolint_rule_options/test.ts Show resolved Hide resolved

camc314 force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from 0606b28 to fd05bcc Compare February 19, 2026 17:17

feat(linter): add typescript/dot-notation rule (#19442)

82ca5c3

graphite-app bot force-pushed the c/02-14-feat_linter_add_typescript_dot-notation_rule branch from fd05bcc to 82ca5c3 Compare February 19, 2026 17:26

graphite-app bot merged commit 82ca5c3 into main Feb 19, 2026
21 checks passed

graphite-app bot deleted the c/02-14-feat_linter_add_typescript_dot-notation_rule branch February 19, 2026 17:33

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 19, 2026

Boshen mentioned this pull request Feb 19, 2026

release(apps): oxlint v1.49.0 && oxfmt v0.34.0 #19553

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(linter): add typescript/dot-notation rule#19442

feat(linter): add typescript/dot-notation rule#19442
graphite-app[bot] merged 1 commit intomainfrom
c/02-14-feat_linter_add_typescript_dot-notation_rule

camc314 commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

connorshea commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026

Uh oh!

connorshea commented Feb 16, 2026 •

edited

Loading

Uh oh!

connorshea commented Feb 16, 2026

Uh oh!

camc314 commented Feb 19, 2026

Uh oh!

camc314 commented Feb 19, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

connorshea commented Feb 16, 2026

Uh oh!

camc314 commented Feb 16, 2026

Uh oh!

connorshea commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

connorshea commented Feb 16, 2026

Uh oh!

camc314 commented Feb 19, 2026

Uh oh!

camc314 commented Feb 19, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Feb 16, 2026 •

edited

Loading

codspeed-hq bot commented Feb 16, 2026 •

edited

Loading

connorshea commented Feb 16, 2026 •

edited

Loading

camc314 commented Feb 19, 2026 •

edited by graphite-app bot

Loading