fix(semantic): make multi_index_vec clone panic-safe#19299
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 12, 2026
Merged
fix(semantic): make multi_index_vec clone panic-safe#19299graphite-app[bot] merged 1 commit intomainfrom
graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to #19138 that addresses panic-safety in the macro-generated Clone implementation for multi_index_vec!, and keeps oxc_semantic integration tests clippy-clean under strict lint settings.
Changes:
- Rework
multi_index_vec!’sCloneimplementation to clone row-by-row usingpush, avoiding settinglenbefore initialization is complete. - Add
#[expect(clippy::unused_self, reason = ...)]to cfg-disabled integration helper methods to keep strict clippy runs warning-free.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/oxc_semantic/src/multi_index_vec.rs | Changes macro-generated Clone to be panic-safe by building the clone incrementally via push. |
| crates/oxc_semantic/tests/integration/util/mod.rs | Suppresses clippy::unused_self for cfg-disabled helper methods while preserving consistent signatures. |
Merging this PR will not alter performance
Comparing 
Footnotes
|
## Summary Follow-up to #19138 after merge. This PR fixes panic-safety in `multi_index_vec!` clone and keeps strict lint clean for `oxc_semantic` tests. ### Changes - Make macro-generated `Clone` panic-safe by cloning row-by-row through `push`. - Avoids setting `len` before all elements are initialized. - Prevents dropping uninitialized elements if a field `clone()` panics. - Add `#[expect(clippy::unused_self)]` to cfg-disabled integration helper methods to keep `cargo clippy -p oxc_semantic --lib --tests -D warnings` green. ## Validation - `cargo clippy -p oxc_semantic --lib --tests -- -D warnings` - `just lint` ## AI disclosure AI-assisted: I used Codex to draft and apply this patch, then ran lint checks and reviewed the result before opening this PR.
graphite-app
bot
force-pushed
the
boshen/multi-index-vec-followup
branch
from
a791f94 to
bfb15a3
Compare
Limerio
pushed a commit
to Limerio/oxc
that referenced
this pull request
Feb 12, 2026
## Summary Follow-up to oxc-project#19138 after merge. This PR fixes panic-safety in `multi_index_vec!` clone and keeps strict lint clean for `oxc_semantic` tests. ### Changes - Make macro-generated `Clone` panic-safe by cloning row-by-row through `push`. - Avoids setting `len` before all elements are initialized. - Prevents dropping uninitialized elements if a field `clone()` panics. - Add `#[expect(clippy::unused_self)]` to cfg-disabled integration helper methods to keep `cargo clippy -p oxc_semantic --lib --tests -D warnings` green. ## Validation - `cargo clippy -p oxc_semantic --lib --tests -- -D warnings` - `just lint` ## AI disclosure AI-assisted: I used Codex to draft and apply this patch, then ran lint checks and reviewed the result before opening this PR.
camc314
pushed a commit
that referenced
this pull request
Feb 16, 2026
### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (#19306) (Boshen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #19138 after merge.
This PR fixes panic-safety in
multi_index_vec!clone and keeps strict lint clean foroxc_semantictests.Changes
Clonepanic-safe by cloning row-by-row throughpush.lenbefore all elements are initialized.clone()panics.#[expect(clippy::unused_self)]to cfg-disabled integration helper methods to keepcargo clippy -p oxc_semantic --lib --tests -D warningsgreen.Validation
cargo clippy -p oxc_semantic --lib --tests -- -D warningsjust lintAI disclosure
AI-assisted: I used Codex to draft and apply this patch, then ran lint checks and reviewed the result before opening this PR.