fix(isolated-declarations): align readonly class array initializer diagnostics with tsc#19218
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 10, 2026
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
camc314
force-pushed
the
c/02-10-refactor_isolated-declarations_remove_dead_branch
branch
2 times, most recently
from
26d32f1 to
af82941
Compare
camc314
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns oxc_isolated_declarations diagnostics for readonly class properties initialized with array literals to match tsc behavior under --isolatedDeclarations, and updates the test suite accordingly.
Changes:
- Emit TS9017 (“Only const arrays can be inferred…”) for readonly class properties initialized with non-const array literals, producing
unknownin the generated.d.ts. - Add/update fixtures covering a broad set of readonly array initializer variations.
- Regenerate/update snapshots to reflect the new
.d.tsoutput and diagnostics.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_isolated_declarations/src/class.rs | Adds a targeted readonly-class-property array-literal check to emit TS9017 + unknown. |
| crates/oxc_isolated_declarations/tests/fixtures/readonly-class-property-initializer.ts | Extends fixture coverage to readonly array initializer cases. |
| crates/oxc_isolated_declarations/tests/fixtures/readonly-class-property-variations.ts | New fixture covering many readonly array initializer patterns. |
| crates/oxc_isolated_declarations/tests/snapshots/readonly-class-property-initializer.snap | Updates expected .d.ts + TS9017 diagnostics for new fixture cases. |
| crates/oxc_isolated_declarations/tests/snapshots/readonly-class-property-variations.snap | New snapshot for the new variations fixture. |
camc314
force-pushed
the
c/02-10-refactor_isolated-declarations_remove_dead_branch
branch
from
af82941 to
4ac5780
Compare
Dunqing
approved these changes
Feb 10, 2026
Member
Merge activity
|
…agnostics with tsc (#19218)
graphite-app
bot
force-pushed
the
c/02-10-refactor_isolated-declarations_remove_dead_branch
branch
from
4ac5780 to
3e0e5ba
Compare
graphite-app
bot
deleted the
c/02-10-refactor_isolated-declarations_remove_dead_branch
branch
owjs3901
pushed a commit
to owjs3901/oxc
that referenced
this pull request
Feb 11, 2026
…agnostics with tsc (oxc-project#19218)
camc314
pushed a commit
that referenced
this pull request
Feb 16, 2026
### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (#19306) (Boshen)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.