perf(transformer): remove TS-only nodes earlier in `enter_statements` by Dunqing · Pull Request #19166 · oxc-project/oxc

Dunqing · 2026-02-09T08:54:59Z

Move the removal of TS-only nodes earlier from exit_statements to enter_statements to avoid deep traversal into the TS-only child nodes, which are never used.

Dunqing · 2026-02-09T08:55:15Z

perf(transformer): remove TS-only nodes earlier in enter_statements #19166 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-02-09T09:00:40Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier (bc28c43) with main (f16f2b6)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (e21428f) during the generation of this report, so f16f2b6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

overlookmotel

Nice! Benchmarks seem to show slight perf loss instead of gain on this PR, which I don't understand, as it seems like a clear win. I think we can probably chalk that up to some oddity of CodSpeed.

Pushed a couple of nit commits (comments typo/formatting). And requested Copilot review to see if he catches anything. Assuming he doesn't, will merge.

overlookmotel · 2026-02-11T15:31:38Z

Merge activity

Feb 11, 3:31 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 11, 3:31 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
Feb 11, 3:46 PM UTC: Merged by the Graphite merge queue.

…#19166) Move the removal of TS-only nodes earlier from `exit_statements` to `enter_statements` to avoid deep traversal into the TS-only child nodes, which are never used.

### 🚀 Features - 429d876 semantic: Assign ast node ids during semantic build (#19263) (Boshen) - ebb80b3 ast: Add `node_id` field to all AST struct nodes (#18138) (Boshen) ### 🐛 Bug Fixes - bfb15a3 semantic: Make multi_index_vec clone panic-safe (#19299) (Boshen) - 41c50a5 transformer: Ignore invalid JSX pragma identifiers (#19296) (Boshen) - deed3d8 transformer: Remove unnecessary trailing expression in object rest spread assignment (#19259) (Boshen) - 5bdaacc transformer: Propagate source spans for sourcemap correctness (#19258) (Boshen) - 3e0e5ba isolated-declarations: Align readonly class array initializer diagnostics with tsc (#19218) (camc314) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red) - aa1e1a8 allocator: Inline BitSet accessors (#19331) (Boshen) - 5b90d46 semantic: Improve SoA with multi index vec (#19138) (Boshen) - 99ce2a6 isolated_declarations: Mark all diagnostic functions as `#[cold]` (#19279) (camc314) - dd0220f transformer: Remove TS-only nodes earlier in `enter_statements` (#19166) (Dunqing) - e5baf60 isolated-declarations: Replace hash collections with index-based Vec (#19221) (Dunqing) ### 📚 Documentation - 569aa61 rust: Add missing rustdocs and remove missing_docs lint attrs (#19306) (Boshen)

github-actions bot added the A-transformer Area - Transformer / Transpiler label Feb 9, 2026

github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Feb 9, 2026

Dunqing force-pushed the 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier branch 2 times, most recently from 0b17b53 to 8977999 Compare February 10, 2026 08:08

Dunqing marked this pull request as ready for review February 10, 2026 08:17

Dunqing requested a review from overlookmotel as a code owner February 10, 2026 08:17

Dunqing force-pushed the 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier branch from 8977999 to 3f962ef Compare February 10, 2026 08:21

Dunqing assigned overlookmotel Feb 11, 2026

overlookmotel force-pushed the 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier branch from 3f962ef to bc28c43 Compare February 11, 2026 15:12

overlookmotel changed the title ~~perf(transformer): remove TS-only nodeds earlier in enter_statements~~ perf(transformer): remove TS-only nodes earlier in enter_statements Feb 11, 2026

overlookmotel requested a review from Copilot February 11, 2026 15:23

Copilot started reviewing on behalf of overlookmotel February 11, 2026 15:23 View session

overlookmotel approved these changes Feb 11, 2026

View reviewed changes

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 11, 2026

perf(transformer): remove TS-only nodes earlier in enter_statements (…

dd0220f

…#19166) Move the removal of TS-only nodes earlier from `exit_statements` to `enter_statements` to avoid deep traversal into the TS-only child nodes, which are never used.

graphite-app bot force-pushed the 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier branch from bc28c43 to dd0220f Compare February 11, 2026 15:32

graphite-app bot merged commit dd0220f into main Feb 11, 2026
21 checks passed

graphite-app bot deleted the 02-09-perf_transformer_remove_ts-only_nodeds_in_earlier branch February 11, 2026 15:46

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 11, 2026

Boshen mentioned this pull request Feb 16, 2026

release(crates): oxc v0.114.0 #19429

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

perf(transformer): remove TS-only nodes earlier in `enter_statements`#19166

perf(transformer): remove TS-only nodes earlier in `enter_statements`#19166
graphite-app[bot] merged 1 commit intomainfrom
02-09-perf_transformer_remove_ts-only_nodeds_in_earlier

Dunqing commented Feb 9, 2026 •

edited

Loading

Uh oh!

Dunqing commented Feb 9, 2026

Uh oh!

codspeed-hq bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

overlookmotel left a comment

Uh oh!

overlookmotel commented Feb 11, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Dunqing commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dunqing commented Feb 9, 2026

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

overlookmotel left a comment

Choose a reason for hiding this comment

Uh oh!

overlookmotel commented Feb 11, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Dunqing commented Feb 9, 2026 •

edited

Loading

codspeed-hq bot commented Feb 9, 2026 •

edited

Loading

overlookmotel commented Feb 11, 2026 •

edited by graphite-app bot

Loading