refactor(linter/plugins): add hasSuggestions to RuleDetails#18962
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
github-actions
bot
added
A-linter
This was referenced Feb 5, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 5, 2026
overlookmotel
force-pushed
the
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
branch
from
3dd8ddd to
0f5851d
Compare
overlookmotel
force-pushed
the
om/02-04-refactor_linter_plugins_add_hassuggestions_to_ruledetails_
branch
from
2cabda5 to
4a553e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure support for rule suggestions by introducing the hasSuggestions field to RuleDetails. This is preparatory work for full suggestions support, storing and validating the rule.meta.hasSuggestions metadata property.
Changes:
- Added
hasSuggestionsboolean field to theRuleDetailsBaseinterface - Implemented validation logic for
rule.meta.hasSuggestionsthat ensures it's eithertrue,false, ornull/undefined - Initialized and assigned the
hasSuggestionsvalue during rule registration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
changed the base branch from
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
to
graphite-base/18962
overlookmotel
force-pushed
the
graphite-base/18962
branch
from
0f5851d to
86047f9
Compare
overlookmotel
force-pushed
the
om/02-04-refactor_linter_plugins_add_hassuggestions_to_ruledetails_
branch
from
4a553e1 to
ba0aeda
Compare
overlookmotel
changed the base branch from
graphite-base/18962
to
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
graphite-app
bot
changed the base branch from
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
to
main
overlookmotel
force-pushed
the
om/02-04-refactor_linter_plugins_add_hassuggestions_to_ruledetails_
branch
from
ba0aeda to
274d089
Compare
camc314
approved these changes
Feb 5, 2026
Contributor
Merge activity
|
Store and validate `rule.meta.hasSuggestions`. This is a pre-condition for supporting suggestions.
graphite-app
bot
force-pushed
the
om/02-04-refactor_linter_plugins_add_hassuggestions_to_ruledetails_
branch
from
274d089 to
df6817e
Compare
graphite-app
bot
deleted the
om/02-04-refactor_linter_plugins_add_hassuggestions_to_ruledetails_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store and validate
rule.meta.hasSuggestions. This is a pre-condition for supporting suggestions.