refactor(linter/plugins): split getFixes into 2 functions#18958
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the getFixes function by splitting it into two separate functions to improve code modularity and enable code reuse for future features.
Changes:
- Split
getFixesinto two functions:getFixes(public) andgetFixesFromFixFn(private) getFixesnow handles fix function type checking andisFixablevalidationgetFixesFromFixFnhandles calling the fix function and processing its return value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Pure refactor. Split `getFixes` into 2 functions. New function `getFixesFromFixFn` calls a fix function and processes the fixes it returns. `getFixesFromFixFn` will also be used for getting the fixes for suggestions in a later PR.
graphite-app
bot
force-pushed
the
om/02-04-refactor_linter_plugins_split_getfixes_into_2_functions
branch
from
94120f2 to
28f9fdb
Compare
graphite-app
bot
deleted the
om/02-04-refactor_linter_plugins_split_getfixes_into_2_functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Split
getFixesinto 2 functions. New functiongetFixesFromFixFncalls a fix function and processes the fixes it returns.getFixesFromFixFnwill also be used for getting the fixes for suggestions in a later PR.