test(linter/plugins): add ability to fix suggestions in JS plugins tests#18961
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 5, 2026
Conversation
This was referenced Feb 5, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
This was referenced Feb 5, 2026
overlookmotel
force-pushed
the
om/02-04-test_linter_plugins_reduce_repetition_in_runfixture_
branch
from
0d97095 to
bc22023
Compare
overlookmotel
force-pushed
the
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
branch
from
3dd8ddd to
0f5851d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for testing the --fix-suggestions flag in the oxlint test framework. The changes enable test fixtures to opt-in to running oxlint with the --fix-suggestions CLI option and recording the results in snapshots.
Changes:
- Added
fixSuggestionsboolean property to the test fixture options interface - Implemented test execution logic for
--fix-suggestionsflag following the existing--fixpattern - Updated validation logic and error messages to include the new option
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/test/utils.ts | Added fixSuggestions property to Fixture interface, default options, and type validation |
| apps/oxlint/test/e2e.test.ts | Implemented test execution logic for --fix-suggestions flag with proper snapshot naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
…sts (#18961) Add ability to run `oxlint` with `--fix-suggestions` flag in tests.
graphite-app
bot
force-pushed
the
om/02-04-test_linter_plugins_reduce_repetition_in_runfixture_
branch
from
bc22023 to
cae8e95
Compare
graphite-app
bot
force-pushed
the
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
branch
from
0f5851d to
86047f9
Compare
Base automatically changed from
om/02-04-test_linter_plugins_reduce_repetition_in_runfixture_
to
main
February 5, 2026 02:51
graphite-app
bot
deleted the
om/02-04-test_linter_plugins_add_ability_to_fix_suggestions_in_js_plugins_tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to run
oxlintwith--fix-suggestionsflag in tests.