test(linter/plugins): conformance tester allow skipping tests which did not run with RuleTester#18677
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Conversation
Member
Author
This was referenced Jan 28, 2026
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the conformance tester to allow skipping tests that weren't run with the correct RuleTester. Previously, the "Test case was not run with RuleTester" error was handled separately and couldn't be skipped through the shouldSkipTest logic. Now, all error types flow through the same skip test mechanism.
Changes:
- Restructured error handling in the
itfunction to ensure all errors (including "not run with RuleTester" errors) go throughshouldSkipTestlogic - Created a minimal test case object
{ code }whencurrentTestis null to enable skip logic evaluation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ddd2ea2 to
6b95c75
Compare
Contributor
Merge activity
|
…id not run with `RuleTester` (#18677) In conformance tester, process errors for when a test case was not run with the correct `RuleTester` in the same way as other errors. This allows skipping them if this behavior is expected (e.g. unit tests which don't use `RuleTester`).
6b95c75 to
22762c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In conformance tester, process errors for when a test case was not run with the correct
RuleTesterin the same way as other errors. This allows skipping them if this behavior is expected (e.g. unit tests which don't useRuleTester).