Skip to content

test(linter/plugins): conformance tester allow skipping tests which did not run with RuleTester#18677

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_
Jan 28, 2026
Merged

test(linter/plugins): conformance tester allow skipping tests which did not run with RuleTester#18677
graphite-app[bot] merged 1 commit intomainfrom
om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 28, 2026

In conformance tester, process errors for when a test case was not run with the correct RuleTester in the same way as other errors. This allows skipping them if this behavior is expected (e.g. unit tests which don't use RuleTester).

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Jan 28, 2026
Copy link
Member Author

overlookmotel commented Jan 28, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the conformance tester to allow skipping tests that weren't run with the correct RuleTester. Previously, the "Test case was not run with RuleTester" error was handled separately and couldn't be skipped through the shouldSkipTest logic. Now, all error types flow through the same skip test mechanism.

Changes:

  • Restructured error handling in the it function to ensure all errors (including "not run with RuleTester" errors) go through shouldSkipTest logic
  • Created a minimal test case object { code } when currentTest is null to enable skip logic evaluation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel self-assigned this Jan 28, 2026
@overlookmotel overlookmotel force-pushed the om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_ branch from ddd2ea2 to 6b95c75 Compare January 28, 2026 22:37
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 28, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 28, 2026

Merge activity

…id not run with `RuleTester` (#18677)

In conformance tester, process errors for when a test case was not run with the correct `RuleTester` in the same way as other errors. This allows skipping them if this behavior is expected (e.g. unit tests which don't use `RuleTester`).
@graphite-app graphite-app bot force-pushed the om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_ branch from 6b95c75 to 22762c1 Compare January 28, 2026 23:02
@graphite-app graphite-app bot merged commit 22762c1 into main Jan 28, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_ branch January 28, 2026 23:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants