Skip to content

test(linter/plugins): conformance tester allow skipping tests which did not run with RuleTester #18677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 28, 2026
Merged

test(linter/plugins): conformance tester allow skipping tests which did not run with RuleTester #18677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions apps/oxlint/conformance/src/capture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,18 +113,20 @@ export function it(code: string, fn: () => void): void {

testResult.isPassed = true;
} catch (err) {
testResult.testCase = currentTest;
if (currentTest === null) {
// oxlint-disable-next-line no-ex-assign
err = new Error("Test case was not run with `RuleTester`");
currentTest = { code };
} else if (!(err instanceof Error)) {
// oxlint-disable-next-line no-ex-assign
err = new Error("Unknown error");
}

if (!(err instanceof Error)) {
testResult.error = new Error("Unknown error");
} else if (currentTest === null) {
testResult.error = new Error("Test case was not run with `RuleTester`");
} else {
testResult.error = err;
testResult.testCase = currentTest;
testResult.error = err;

const ruleName = describeStack[0];
if (shouldSkipTest(ruleName, currentTest, code, err)) testResult.isSkipped = true;
}
const ruleName = describeStack[0];
if (shouldSkipTest(ruleName, currentTest, code, err)) testResult.isSkipped = true;
} finally {
// Reset current test
currentTest = null;
Expand Down
Loading