test(linter/plugins): conformance tester catch errors in describe callbacks#18678
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 28, 2026
Conversation
Member
Author
This was referenced Jan 28, 2026
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the conformance tester's error handling by catching errors that occur within describe() callback functions and converting them into failing test cases, rather than causing the entire test file to fail to load.
Changes:
- Added promise detection and handling for
describe()callbacks that incorrectly return promises - Added error catching in
describe()that converts errors into test cases usingit() - Modified control flow to properly manage the
describeStackin both success and error scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9f89c2d to
8ae77ab
Compare
ddd2ea2 to
6b95c75
Compare
Contributor
Merge activity
|
…allbacks (#18678) Catch errors in `describe(() => { ... })` blocks and turn them into test cases. This results in a failing test rather than the whole test file failing to load.
6b95c75 to
22762c1
Compare
8ae77ab to
f9949a0
Compare
Base automatically changed from
om/01-28-test_linter_plugins_conformance_tester_allow_skipping_tests_which_did_not_run_with_ruletester_
to
main
January 28, 2026 23:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Catch errors in
describe(() => { ... })blocks and turn them into test cases. This results in a failing test rather than the whole test file failing to load.