feat(semantic): add TS1049 code to diagnostic by camc314 · Pull Request #18535 · oxc-project/oxc

camc314 · 2026-01-25T18:22:26Z

https://github.com/microsoft/typescript/blob/16b933fb7bff04371fe9ec8525a8e90afa3174d4/src/compiler/diagnosticMessages.json#L146-L149

camc314 · 2026-01-25T18:22:41Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR adds the TypeScript error code TS(1049) to the diagnostic message for set accessors that don't have exactly one parameter, improving compatibility with TypeScript's error reporting.

Changes:

Updated setter_with_parameters diagnostic to use ts_error with code "1049" instead of plain OxcDiagnostic::error
Updated snapshot tests to reflect the new error message format with the TS(1049) prefix

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_parser/src/diagnostics.rs	Modified `setter_with_parameters` to use `ts_error("1049", ...)` for TypeScript-compatible error reporting
tasks/coverage/snapshots/parser_typescript.snap	Updated 9 test snapshots to include the TS(1049) error code prefix
tasks/coverage/snapshots/parser_babel.snap	Updated 10 test snapshots to include the TS(1049) error code prefix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

camchenry · 2026-01-25T18:30:11Z

Merge activity

Jan 25, 6:30 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 25, 6:31 PM UTC: camchenry added this pull request to the Graphite merge queue.
Jan 25, 6:43 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jan 25, 6:43 PM UTC: Merged by the Graphite merge queue.

https://github.com/microsoft/typescript/blob/16b933fb7bff04371fe9ec8525a8e90afa3174d4/src/compiler/diagnosticMessages.json#L146-L149

### 💥 BREAKING CHANGES - 22dec6a semantic: [**BREAKING**] Remove `Scoping::scope_build_child_ids` and all related APIs (#18362) (Dunqing) - 30a4899 oxc: [**BREAKING**] Remove `CompilerInterface::semantic_child_scope_ids` (#18361) (Dunqing) - 777fc40 ast: [**BREAKING**] Add `Ident` type (#18354) (Boshen) - af0ca46 span: [**BREAKING**] Use `ModuleKind::CommonJS` for `SourceType::cjs()` (#18276) (sapphi-red) ### 🚀 Features - 0a02026 semantic: Add TS1499 code to diagnostic (#18557) (camc314) - 8b4618f parser: Add TS1500 code to diagnostic (#18547) (camc314) - 866b6b3 parser: Add TS1048 code to diagnostic (#18546) (camc314) - 1117c44 parser: Add TS1054 code to diagnostic (#18541) (camc314) - e4fcdde semantic: Add TS1053 code to diagnostic (#18539) (camc314) - bcbf396 semantic: Add TS1052 code to diagnostic (#18538) (camc314) - 8155edf semantic: Add TS1049 code to diagnostic (#18535) (camc314) - 51d3b3f parser: Add TS1502 code to diagnostic (#18534) (camc314) - 00854e8 semantic: Add TS2337 error code to super call diagnostic (#18531) (camc314) - 993fd2b parser: Parse unambiguous await with better error messages (#18480) (Boshen) - 8db0e78 linter/plugins: Handle BOMs (#18376) (overlookmotel) - 6ac09e2 linter/plugins: Support source text not being at start of buffer (#18375) (overlookmotel) - 2ef5647 ast: Add escape_raw parameter to template_element builders (#18121) (Boshen) ### 🐛 Bug Fixes - 74d0998 semantic: Update error msg for multiple `default` cases in switch stmt (#18526) (camc314) - c205b0d ast: Remove `ThisExpression` from `TSModuleReference` (#18489) (Boshen) - aed3669 parser: Parse HTML-like comments in unambiguous mode (#18442) (Boshen) - c4132fb parser: Validate accessor parameters in interface method signatures (#18391) (Boshen) - b0cd74d semantic: Allow `var` and `function` with same name in static blocks (#18358) (Boshen) - 6037995 semantic: Allow `new.target` in class field initializers (#18349) (Boshen) - 9a15c6a semantic: Do not rely on spans for node comparison in `Function::bind` (#18296) (overlookmotel) ### ⚡ Performance - 6b600c4 semantic: Skip parent lookup for function declarations in `Function::bind` (#18293) (overlookmotel) - c27ad2d semantic: Move check for function declaration out of `is_function_part_of_if_statement` (#18292) (overlookmotel) - 63eb89e semantic: Skip checking redeclarations for function expressions (#18291) (overlookmotel) - 7c12743 semantic: Skip checking unresolved exports in CommonJS files (#18250) (overlookmotel) - 2349031 allocator: Increase initial chunk size from 512B to 16KB (#18234) (Boshen) ### 📚 Documentation - 8ccd853 npm: Update package homepage URLs and add keywords (#18509) (Boshen) - 9b3165f napi/parser: Clarify when to use `parseAsync` vs `parseSync` (#18486) (Boshen) - 1b59f63 napi/parser: Correct typo in README (#18251) (overlookmotel) - 00ff75f mangler: Fix `top_level` option in example (#18233) (overlookmotel) - 2ddc073 semantic: Fix typo in comment (#18238) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

camc314 marked this pull request as ready for review January 25, 2026 18:22

Copilot AI review requested due to automatic review settings January 25, 2026 18:22

github-actions bot added the A-parser Area - Parser label Jan 25, 2026

github-actions bot added the C-enhancement Category - New feature or request label Jan 25, 2026

This was referenced Jan 25, 2026

feat(parser): add TS1502 code to diagnostic #18534

Merged

refactor(semantic): rename diagnosic function name #18536

Merged

Copilot started reviewing on behalf of camc314 January 25, 2026 18:22 View session

Copilot AI reviewed Jan 25, 2026

View reviewed changes

camchenry approved these changes Jan 25, 2026

View reviewed changes

camchenry added the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026

This was referenced Jan 25, 2026

feat(semantic): add TS1052 code to diagnostic #18538

Merged

feat(semantic): add TS1053 code to diagnostic #18539

Merged

style(semantic): reorder diagnostic functions #18540

Merged

feat(parser): add TS1054 code to diagnostic #18541

Merged

feat(semantic): add TS1049 code to diagnostic (#18535)

8155edf

https://github.com/microsoft/typescript/blob/16b933fb7bff04371fe9ec8525a8e90afa3174d4/src/compiler/diagnosticMessages.json#L146-L149

graphite-app bot force-pushed the c/01-25-feat_semantic_add_ts1502_code_to_diagnostic branch from 703c7f1 to 51d3b3f Compare January 25, 2026 18:32

graphite-app bot force-pushed the c/01-25-feat_semantic_add_ts1049_code_to_diagnostic branch from 638dff9 to 8155edf Compare January 25, 2026 18:32

Base automatically changed from c/01-25-feat_semantic_add_ts1502_code_to_diagnostic to main January 25, 2026 18:38

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 25, 2026

graphite-app bot merged commit 8155edf into main Jan 25, 2026
23 checks passed

graphite-app bot deleted the c/01-25-feat_semantic_add_ts1049_code_to_diagnostic branch January 25, 2026 18:43

This was referenced Jan 25, 2026

feat(parser): add TS1048 code to diagnostic #18546

Merged

feat(parser): add TS1500 code to diagnostic #18547

Merged

feat(semantic): add TS1499 code to diagnostic #18557

Merged

Boshen mentioned this pull request Jan 26, 2026

release(crates): oxc v0.111.0 #18572

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(semantic): add TS1049 code to diagnostic#18535

feat(semantic): add TS1049 code to diagnostic#18535
graphite-app[bot] merged 1 commit intomainfrom
c/01-25-feat_semantic_add_ts1049_code_to_diagnostic

camc314 commented Jan 25, 2026 •

edited

Loading

Uh oh!

camc314 commented Jan 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

camchenry commented Jan 25, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

camc314 commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

camchenry commented Jan 25, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camc314 commented Jan 25, 2026 •

edited

Loading

camc314 commented Jan 25, 2026 •

edited

Loading

camchenry commented Jan 25, 2026 •

edited by graphite-app bot

Loading