feat(span)!: use ModuleKind::CommonJS for SourceType::cjs()

[sapphi-red]

Follow-up to #18089.

Maybe we should add SourceType::script() so that it's easier to create a SourceType with ModuleType::Script.

[sapphi-red]

• test(minifier): add test to ensure top-level variables are removed for CJS files #18279
• feat(span)!: use ModuleKind::CommonJS for SourceType::cjs() #18276 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-20-feat_span_use_modulekind_commonjs_for_sourcetype_cjs_ (ab714de) with main (78ca6ee)¹}

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks²

Footnotes

1. No successful run was found on main (c1260cb) during the generation of this report, so 78ca6ee was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This is a follow-up to #18089 that changes SourceType::cjs() to use ModuleKind::CommonJS instead of ModuleKind::Script. This breaking change better reflects the semantic meaning of CommonJS modules, which are wrapped in functions and support top-level return and new.target.

Changes:

• Updated SourceType::cjs() to return ModuleKind::CommonJS instead of ModuleKind::Script
• Updated call sites that require script mode to explicitly call .with_script(true)
• Removed special case in napi/minify for .js files to use standard path-based detection

Reviewed changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_span/src/source_type.rs	Changes cjs() to use ModuleKind::CommonJS, updates documentation and examples
tasks/minsize/src/lib.rs	Adds .with_script(true) for script mode testing
tasks/coverage/src/test262/mod.rs	Adds .with_script(true) for Test262 script tests
tasks/coverage/src/runtime/mod.rs	Adds .with_script(!is_module) for conditional script/module handling
tasks/coverage/src/node_compat_table/mod.rs	Adds .with_script(true) for script mode execution
napi/minify/src/lib.rs	Removes special .js file handling and unused import, now uses standard from_path() detection
crates/oxc_minifier/tests/peephole/remove_unused_expression.rs	Adds .with_script(true) for script mode testing
crates/oxc_minifier/tests/peephole/remove_unused_declaration.rs	Adds .with_script(true) for script mode testing
crates/oxc_minifier/tests/peephole/inline_single_use_variable.rs	Adds .with_script(true) for script mode testing

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[graphite-app]

Merge activity

• Jan 20, 6:07 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Jan 20, 6:15 AM UTC: Merged by the Graphite merge queue.