Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_parser/src/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ pub fn reg_exp_flag_u_and_v(span: Span) -> OxcDiagnostic {

#[cold]
pub fn setter_with_parameters(span: Span, parameters_count: usize) -> OxcDiagnostic {
OxcDiagnostic::error("A 'set' accessor must have exactly one parameter.")
ts_error("1049", "A 'set' accessor must have exactly one parameter.")
.with_label(span)
.with_help(if parameters_count == 0 {
"Add a parameter here"
Expand Down
20 changes: 10 additions & 10 deletions tasks/coverage/snapshots/parser_babel.snap
Original file line number Diff line number Diff line change
Expand Up @@ -788,14 +788,14 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: Remove these parameters here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/core/object/invalid-setter-no-param/input.js:1:9]
1 │ ({ set x(){} })
· ──
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/core/object/invalid-setter-two-params/input.js:1:12]
1 │ ({ set prop(x, y) {} })
· ──────
Expand Down Expand Up @@ -4378,14 +4378,14 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: Remove these parameters here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/es2015/uncategorised/346/input.js:1:19]
1 │ class A { set prop() {} }
· ──
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/es2015/uncategorised/347/input.js:1:19]
1 │ class A { set prop(x, y) {} }
· ──────
Expand Down Expand Up @@ -10765,7 +10765,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
· ─
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0075/input.js:1:9]
1 │ ({ set s() { } })
· ──
Expand Down Expand Up @@ -12042,7 +12042,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
3 │ }
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/estree/typescript/getter-setter/input.ts:3:9]
2 │ ({ get x() { return 1 } });
3 │ ({ set x() {} });
Expand Down Expand Up @@ -13296,7 +13296,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: Remove these parameters here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-parameters/input.ts:3:10]
2 │ get foo(param): string;
3 │ set foo();
Expand All @@ -13313,7 +13313,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
3 │ }
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter/input.ts:2:10]
1 │ interface Foo {
2 │ set bar(...v);
Expand All @@ -13330,7 +13330,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
3 │ }
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-reset-parameter-babel-7/input.ts:2:10]
1 │ interface Foo {
2 │ set bar(...v);
Expand Down Expand Up @@ -13363,7 +13363,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
4 │ }
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/interface/get-set-invalid-this-parameters/input.ts:3:10]
2 │ get bar(this: Foo);
3 │ set bar(this: Foo);
Expand Down
18 changes: 9 additions & 9 deletions tasks/coverage/snapshots/parser_typescript.snap
Original file line number Diff line number Diff line change
Expand Up @@ -16041,7 +16041,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
10 │ }
╰────

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/es6/computedProperties/computedPropertyNames49_ES5.ts:9:16]
8 │ },
9 │ set [1 + 1]() {
Expand All @@ -16050,7 +16050,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/es6/computedProperties/computedPropertyNames49_ES6.ts:9:16]
8 │ },
9 │ set [1 + 1]() {
Expand All @@ -16059,7 +16059,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/es6/computedProperties/computedPropertyNames50_ES5.ts:11:16]
10 │ },
11 │ set [1 + 1]() {
Expand All @@ -16068,7 +16068,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/es6/computedProperties/computedPropertyNames50_ES6.ts:11:16]
10 │ },
11 │ set [1 + 1]() {
Expand Down Expand Up @@ -21153,14 +21153,14 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Remove these parameters here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/Accessors/parserAccessors8.ts:1:18]
1 │ var v = { set foo() { } }
· ──
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/Accessors/parserAccessors9.ts:1:18]
1 │ var v = { set foo(a, b) { } }
· ──────
Expand Down Expand Up @@ -22010,7 +22010,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Try inserting a semicolon here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ErrorRecovery/parserErrantSemicolonInClass1.ts:15:17]
14 │ }
15 │ public set d() {
Expand Down Expand Up @@ -22494,7 +22494,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Remove these parameters here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/MemberAccessorDeclarations/parserMemberAccessorDeclaration13.ts:2:11]
1 │ class C {
2 │ set Foo() { }
Expand All @@ -22503,7 +22503,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/statements/Va
╰────
help: Add a parameter here

× A 'set' accessor must have exactly one parameter.
× TS(1049): A 'set' accessor must have exactly one parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/MemberAccessorDeclarations/parserMemberAccessorDeclaration14.ts:2:11]
1 │ class C {
2 │ set Foo(a: number, b: number) { }
Expand Down
Loading