refactor(linter/plugins): simplify scope analyse options#18305
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 20, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 20, 2026
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the initialization of analyzeOptions passed to the TS-ESLint scope analyzer by simplifying the type and providing complete property initialization with proper defaults.
Changes:
- Removed unused imports (
typeAssertIs,SetNullable) - Changed
analyzeOptionstype fromSetNullable<AnalyzeOptions, "sourceType">toAnalyzeOptionswith all properties explicitly defined - Added missing properties (
childVisitorKeys,impliedStrict,emitDecoratorMetadata) with appropriate default values - Reordered properties to match the
AnalyzeOptionstype definition order - Removed unnecessary
typeAssertIscall since the object now has the correct type from initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Pure refactor. Simplify initialization of `analyzeOptions` passed to TS-ESLint scope analyzer. Also fill in all the options, and order properties in same order as the `AnalyzeOptions` type.
graphite-app
bot
force-pushed
the
om/01-20-refactor_linter_plugins_simplify_scope_analyse_options
branch
from
05ca76d to
1691891
Compare
graphite-app
bot
deleted the
om/01-20-refactor_linter_plugins_simplify_scope_analyse_options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Simplify initialization of
analyzeOptionspassed to TS-ESLint scope analyzer. Also fill in all the options, and order properties in same order as theAnalyzeOptionstype.