test(linter/plugins): handle globalReturn and impliedStrict options in conformance tests#18307
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 20, 2026
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Member
Author
Merge activity
|
…ns in conformance tests (#18307) Closes #16862. In conformance tests, support `globalReturn` and `impliedStrict` options. This fixes ~40 failing tests. This PR does not add these options to actually linter, because Oxlint doesn't provide a way to set these options through config. Ideally, we *would* support these options in `RuleTester` in `eslintCompat` mode, but that would add extra code to the main linter implementation. We can do that when we move `RuleTester` into its own package.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the globalReturn and impliedStrict parser options in conformance tests to fix approximately 40 failing tests. These options affect how the scope analyzer interprets the code (allowing top-level return statements and treating code as strict mode), but are only enabled in the conformance test build and not in the main linter.
Changes:
- Added
analyzeOptionsOverrideobject in scope.ts to allow runtime overriding ofglobalReturnandimpliedStrictoptions during conformance tests - Modified
setEcmaVersionContexttosetEcmaVersionAndFeaturesto extract and apply these parser options from test case configuration - Updated type definitions in tester.ts to allow these properties in test case configurations
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/scope.ts | Adds override mechanism for globalReturn and impliedStrict options guarded by CONFORMANCE flag |
| apps/oxlint/src-js/package/rule_tester.ts | Extracts parser options from test cases and applies them to scope analyzer, renames function to reflect expanded functionality |
| apps/oxlint/conformance/tester.ts | Updates type definitions to allow globalReturn and impliedStrict in test case configurations |
| apps/oxlint/conformance/snapshot.md | Shows test pass rate improvements: 2 more rules fully passing, 42 more tests passing overall |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
force-pushed
the
om/01-20-fix_linter_plugins_set_scope_analyse_settings_based_on_source_type
branch
from
43627ec to
44be0eb
Compare
graphite-app
bot
force-pushed
the
om/01-20-test_linter_plugins_handle_globalreturn_and_impliedstrict_options_in_conformance_tests
branch
from
355e6c9 to
4e24692
Compare
Base automatically changed from
om/01-20-fix_linter_plugins_set_scope_analyse_settings_based_on_source_type
to
main
January 20, 2026 18:32
graphite-app
bot
deleted the
om/01-20-test_linter_plugins_handle_globalreturn_and_impliedstrict_options_in_conformance_tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16862.
In conformance tests, support
globalReturnandimpliedStrictoptions. This fixes ~40 failing tests.This PR does not add these options to actually linter, because Oxlint doesn't provide a way to set these options through config.
Ideally, we would support these options in
RuleTesterineslintCompatmode, but that would add extra code to the main linter implementation. We can do that when we moveRuleTesterinto its own package.