Skip to content

refactor(linter/plugins): simplify scope analyse options #18305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 20, 2026
Merged

refactor(linter/plugins): simplify scope analyse options #18305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions apps/oxlint/src-js/plugins/scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { analyze, Variable as TSVariable } from "@typescript-eslint/scope-manage
import { ast, initAst } from "./source_code.ts";
import { globals, envs, initGlobals } from "./globals.ts";
import { ENVS } from "../generated/envs.ts";
import { debugAssert, debugAssertIsNonNull, typeAssertIs } from "../utils/asserts.ts";
import { debugAssert, debugAssertIsNonNull } from "../utils/asserts.ts";

import type {
AnalyzeOptions,
Expand All @@ -15,7 +15,6 @@ import type {
} from "@typescript-eslint/scope-manager";
import type { Writable } from "type-fest";
import type * as ESTree from "../generated/types.d.ts";
import type { SetNullable } from "../utils/types.ts";

export interface Scope {
type: ScopeType;
Expand Down Expand Up @@ -100,12 +99,15 @@ let tsScopeManager: TSESLintScopeManager | null = null;

// Options for TS-ESLint's `analyze` method.
// `sourceType` property is set before calling `analyze`.
const analyzeOptions: SetNullable<AnalyzeOptions, "sourceType"> = {
const analyzeOptions: AnalyzeOptions = {
childVisitorKeys: undefined,
globalReturn: false,
jsxFragmentName: null,
impliedStrict: false,
jsxPragma: "React",
jsxFragmentName: null,
lib: [],
sourceType: null,
sourceType: "module",
emitDecoratorMetadata: false,
};

/**
Expand All @@ -116,7 +118,7 @@ function initTsScopeManager() {
debugAssertIsNonNull(ast);

analyzeOptions.sourceType = ast.sourceType;
typeAssertIs<AnalyzeOptions>(analyzeOptions);

// @ts-expect-error - TODO: Our types don't quite align yet
tsScopeManager = analyze(ast, analyzeOptions);

Expand Down
Loading