Skip to content

test(minifier): add test to ensure top-level variables are removed for CJS files#18279

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files
Jan 20, 2026
Merged

test(minifier): add test to ensure top-level variables are removed for CJS files#18279
graphite-app[bot] merged 1 commit intomainfrom
01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 20, 2026

close #12378

@github-actions github-actions bot added A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 20, 2026
Copy link
Member Author

sapphi-red commented Jan 20, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

Merging this PR will not alter performance

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing 01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files (2e657aa) with 01-20-feat_span_use_modulekind_commonjs_for_sourcetype_cjs_ (ab714de)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red marked this pull request as ready for review January 20, 2026 05:25
@sapphi-red sapphi-red requested a review from Boshen January 20, 2026 05:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 20, 2026
Copy link
Member

Boshen commented Jan 20, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-20-feat_span_use_modulekind_commonjs_for_sourcetype_cjs_ branch from ab714de to 15842cc Compare January 20, 2026 06:07
graphite-app bot pushed a commit that referenced this pull request Jan 20, 2026
@graphite-app graphite-app bot force-pushed the 01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files branch from 2e657aa to 1facf30 Compare January 20, 2026 06:08
@graphite-app graphite-app bot force-pushed the 01-20-feat_span_use_modulekind_commonjs_for_sourcetype_cjs_ branch from 15842cc to af0ca46 Compare January 20, 2026 06:09
@graphite-app graphite-app bot force-pushed the 01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files branch from 1facf30 to 8fbf2d2 Compare January 20, 2026 06:10
Base automatically changed from 01-20-feat_span_use_modulekind_commonjs_for_sourcetype_cjs_ to main January 20, 2026 06:15
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 20, 2026
@graphite-app graphite-app bot merged commit 8fbf2d2 into main Jan 20, 2026
22 checks passed
@graphite-app graphite-app bot deleted the 01-20-test_minifier_add_test_to_ensure_top-level_variables_are_removed_for_cjs_files branch January 20, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minifier: remove top-level variables in CJS

2 participants