feat(vscode): fallback to globally installed oxlint/oxfmt packages by Sysix · Pull Request #18007 · oxc-project/oxc

Sysix · 2026-01-14T19:50:15Z

Sysix · 2026-01-14T19:50:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR adds fallback functionality to search for oxlint/oxfmt binaries in global node_modules when they are not found in project node_modules. The implementation is extracted from ConfigService into a dedicated findBinary module.

Changes:

Created new findBinary.ts module with functions to search for binaries in project node_modules, global node_modules, and user settings
Refactored ConfigService to use the new findBinary functions with global fallback support
Added unit tests for the new findBinary functions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
editors/vscode/client/findBinary.ts	New module containing binary search logic with global node_modules fallback, extracted and enhanced from ConfigService
editors/vscode/client/ConfigService.ts	Refactored to use new findBinary module functions, simplified searchBinaryPath method
editors/vscode/tests/unit/findBinary.spec.ts	New unit tests for the findBinary module functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

editors/vscode/client/findBinary.ts

editors/vscode/tests/unit/findBinary.spec.ts

editors/vscode/client/findBinary.ts

Stanzilla · 2026-01-26T13:42:01Z

@Sysix do you have a rough ETA for this?

camc314 · 2026-01-26T15:27:06Z

Merge activity

Jan 26, 3:27 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 26, 3:27 PM UTC: camc314 added this pull request to the Graphite merge queue.
Jan 26, 3:32 PM UTC: Merged by the Graphite merge queue.

…18007) closes #18005

# Oxlint ### 💥 BREAKING CHANGES - b34a155 linter/plugins: [**BREAKING**] `RuleTester` set `context.filename` to absolute path (#18702) (overlookmotel) ### 🚀 Features - 1753209 linter/vscode: Run extension when JS configs are detected (#18832) (camc314) - c962dd2 linter/lsp: Implement support for oxlint.config.ts (#18826) (camc314) - da32203 linter: Auto generate oxlint.config.ts types (#18597) (camc314) - 19b4df7 oxlint: Introduce `defineConfig` helper (#18596) (camc314) - ea97231 linter: Implement `oxlint.config.ts` support (#17563) (camc314) - 17ca42d linter: Implement `react/no-multi-comp` rule. (#18794) (connorshea) - 88f30e0 linter/plugins: Move eslint compatible plugin conversion to `eslintCompatPlugin` function (#18791) (overlookmotel) - 2a72794 linter/plugins: `RuleTester` take `cwd` property (#18756) (overlookmotel) - 9f533db linter: Add `find_prev_token_within` method for token search (#18769) (camc314) - 772ea70 linter: Introduce `load_js_configs` napi callback (#18767) (camc314) - e9690c1 linter: Introduce `DiscoveredConfig` in preparation for JS configs (#18674) (camc314) - 558b588 linter/prefer-namespace-keyword: Move to correctness (#18733) (camc314) - 7a5c268 oxlint/lsp: Support `jsPlugins` (#17840) (Sysix) - c07497c linter/prefer-modern-dom-apis: Implement suggestion (#17965) (Mikhail Baev) - 8531bc9 linter: Implement `prefer-const` (#18687) (camchenry) - 8670b18 parser: Error on ambient class accessor implementations (#18592) (camc314) - 6b8a5ae linter: Add `eslint-plugin-import/no-nodejs-modules` rule (#18006) (Mikhail Baev) - 04f400d linter/no-duplicates: Add support for `considerQueryString` option (#18657) (camc314) - 3b7f260 linter/consistent-generic-constructor: Implement fixer (#18616) (camc314) - 794f9e4 linter/prefer-exponentation-operator: Implement suggestion (#18602) (camc314) - 773d916 linter: `eslint/sort_keys` ignore leading and trailing spreads in auto-fix (#18485) (Lonami) - 20d4ede linter: Implement `import/no-relative-parent-imports` rule (#18513) (Valentin Maerten) - 0da45ef vscode: Fallback to globally installed oxlint/oxfmt packages (#18007) (Sysix) ### 🐛 Bug Fixes - a3417b1 linter/plugins: Clear state when reloading workspace (#18837) (overlookmotel) - c879992 linter: Error on arrays passed in as config (#18822) (camc314) - 5c80422 linter/tsdown: Ensure relative path for globals import starts with `./` (#18820) (camc314) - 7419dfb linter: Remove invalid debug assersion, add test (#18819) (camc314) - 0ca6269 ci: Fix the repo path normalization logic for tests on Windows. (#18815) (connorshea) - c7b0a65 linter: Fix config option docs for `react/jsx-boolean-value` rule. (#18811) (connorshea) - cce374e linter/prefer-const: Replace entire declaration over just the `let` kw (#18814) (camc314) - 41f92d1 linter: Error when given config options for a lint rule that has no config options defined. (#18809) (connorshea) - 0867a36 linter/consistent-index-object-style: False positive with mapped + generic types (#18801) (camc314) - 1d34b42 linter: Fix 32 bit build (#18783) (camc314) - 95df577 linter/plugins: Handle error from `destroyWorkspace` (#18763) (overlookmotel) - b3261dc linter: Fix the curly rule config to enforce the shape of the config and emit correct docs (#18743) (connorshea) - d981978 linter/plugins: Use non-blocking mode when calling `destroyWorkspace` (#18762) (overlookmotel) - 3f43d4c linter: Accept bools as valid values for `fixable` (#18772) (camc314) - 005910a linter/plugins: Support plugins outside of workspace (#18755) (overlookmotel) - fd92711 vscode: Use `fsPath` for workspace mapping (#18728) (Sysix) - 358b2c1 linter/consistent-generic-constructors: Check bounds when searching for `:` token (#18745) (connorshea) - abd0c28 linter/capitalized-comments: Fix generated rule option docs (#18748) (connorshea) - d90a9f6 linter: Add more tests for `prefer-const`'s fixer and fix its invalid behavior. (#18747) (connorshea) - f82011b oxlint/lsp: Disable JS plugins support in LSP except in tests (#18727) (overlookmotel) - 94505c8 linter/jest: Change `prefer-spy-on` autofix to suggestion (#18152) (Ben Lowery) - 6ec1112 linter: Mark unused disable directive fix as suggestion (#18703) (ddmoney420) - 49609ec linter/no-useless-constructor: Consider argument transformation as used (#18706) (ddmoney420) - 40218de linter: Fix behavior of jsx-a11y/no-static-element-interactions rule. (#17817) (connorshea) - db9751d linter/no-html-link-for-pages: Handle `target=_blank` correctly (#18693) (camc314) - e440b78 linter/plugins: Pass all args to CFG event handlers when 2 rules use same handler (#18683) (overlookmotel) - b393430 linter/curly: Fix multi-or-nest and consistent conflict (#18660) (camc314) - 2e1fbc2 linter/plugins: Implement `context.parserPath` (#18644) (overlookmotel) - 34951ed linter/plugins: `filename` option takes precedence over `parserOptions.lang` in `RuleTester` (#18643) (overlookmotel) - 28df160 linter/plugins: Allow line number passed to `report` to be 0 (#18642) (overlookmotel) - 14fabec vscode: Use built-in `getWorkspaceFolder` for detecting the right workspace of a given uri (#18583) (Sysix) - 0ff4cea oxlint/cli: Report error when nested config could not be parsed (#18504) (Sysix) ### ⚡ Performance - 9862224 linter/plugins: Reduce cost of workspaces (#18758) (overlookmotel) - 6bc0bde linter: Remove string allocation (#18725) (overlookmotel) - 3a6b41e linter/plugins: Replace ESLint Traverser with lightweight traverseNode (#18529) (Rintaro Itokawa) ### 📚 Documentation - dd1a653 linter: Fix doc comment for ignoreStateless config option. (#18808) (connorshea) - 5909085 linter/plugins: Add doc comments (#18753) (overlookmotel) - ffe53a3 linter: Update lint function docs (#18766) (camc314) - b82faec linter: Glob for any css module for no-unassigned-import (#18713) (Ben Stickley) - cd86347 linter: Mark some react rules as unsupported, misc docs improvements (#18617) (connorshea) - 23401d8 linter: Update fixes and suggestions status for tsgolint rules (#18619) (camchenry) # Oxfmt ### 🚀 Features - ee30de9 oxfmt: Add config migration from biome (#18638) (Luca Fischer) ### 🐛 Bug Fixes - e754b18 oxfmt/migrate-prettier: Set `experimentalSortPackagejson: false` by default (#18831) (leaysgur) - a83c266 formatter: Keep decorated function pattern hugged when params break (#18830) (Dunqing) - 0c8efe1 formatter: Quote numeric property keys with `quoteProps: consistent` (#18803) (Dunqing) - 9c14c3e formatter: Ignore comment does not work for sequence expressions in arrow function body (#18799) (Dunqing) - 54984ae formatter: Handle leading comments in arrow function sequence expressions (#18798) (Dunqing) - 61bb2b5 formatter: Correctly expand JSX returned from arrow callbacks in JSX expression containers (#18797) (Dunqing) - 34ee194 formatter: Tailwindcss sorting doesn't work for object property keys (#18773) (Dunqing) - 48f1e35 oxfmt: Prevent ThreadsafeFunction crash on Node.js exit (#18723) (Boshen) - e96adca formatter: Follow Prettier's approach for for-in initializer parentheses (#18695) (Dunqing) - 1215a6f formatter: Preserve quote for class property key in TypeScript (#18692) (Dunqing) - 059acae formatter: Incorrect comments placement for union type in `TSTypeIntersection` (#18690) (Dunqing) - c3d05c1 formatter,oxfmt: Handle CRLF with embedded formatting (#18686) (leaysgur) - 7cb3085 formatter: Preserve comments on rest elements (#18649) (Dunqing) - 21984dd formatter: Preserve type cast comments on rest parameters (#18648) (Dunqing) - 2f70254 formatter: Don't add extra semicolon on suppressed class properties (#18631) (Dunqing) - ac1ff4e oxfmt: Use `empty_line` IR for empty xxx-in-js line (#18623) (leaysgur) - 8f76900 oxfmt: Dedent xxx-in-js templates before calling prettier (#18622) (leaysgur) - 6b726ef oxfmt: Trim whitespace only xxx-in-js templates (#18621) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Jan 14, 2026

Sysix mentioned this pull request Jan 14, 2026

fix(vscode): resolve binary paths with node resolver #17970

Merged

Sysix mentioned this pull request Jan 14, 2026

chore(vscode): format for vscode tests files #17971

Merged

Sysix force-pushed the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch 2 times, most recently from f9d4c26 to 1f56b0c Compare January 14, 2026 20:31

Sysix requested a review from Copilot January 14, 2026 20:35

Copilot started reviewing on behalf of Sysix January 14, 2026 20:35 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

Sysix force-pushed the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch from 1f56b0c to 56ee228 Compare January 16, 2026 15:10

Sysix marked this pull request as ready for review January 16, 2026 15:10

Sysix requested a review from camc314 as a code owner January 16, 2026 15:10

Sysix assigned camc314 Jan 16, 2026

graphite-app bot changed the base branch from 01-13-chore_vscode_format_for_vscode_tests_files to graphite-base/18007 January 18, 2026 15:44

graphite-app bot force-pushed the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch from 56ee228 to e466ff8 Compare January 18, 2026 15:49

graphite-app bot force-pushed the graphite-base/18007 branch from e7d90b3 to a7e2eb2 Compare January 18, 2026 15:49

graphite-app bot changed the base branch from graphite-base/18007 to main January 18, 2026 15:50

graphite-app bot force-pushed the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch 2 times, most recently from 8db8623 to 43e7833 Compare January 18, 2026 15:52

Sysix mentioned this pull request Jan 20, 2026

Unable to configure the vscode extension to use a non-trivial binary #18310

Closed

camc314 approved these changes Jan 26, 2026

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 26, 2026

feat(vscode): fallback to globally installed oxlint/oxfmt packages (#…

0da45ef

…18007) closes #18005

graphite-app bot force-pushed the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch from 43e7833 to 0da45ef Compare January 26, 2026 15:27

graphite-app bot merged commit 0da45ef into main Jan 26, 2026
20 checks passed

graphite-app bot deleted the 01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages branch January 26, 2026 15:32

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 26, 2026

Boshen mentioned this pull request Feb 2, 2026

release(apps): oxlint v1.43.0 && oxfmt v0.28.0 #18843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(vscode): fallback to globally installed oxlint/oxfmt packages#18007

feat(vscode): fallback to globally installed oxlint/oxfmt packages#18007
graphite-app[bot] merged 1 commit intomainfrom
01-14-feat_vscode_fallback_to_globally_installed_oxlint_oxfmt_packages

Sysix commented Jan 14, 2026 •

edited

Loading

Uh oh!

Sysix commented Jan 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stanzilla commented Jan 26, 2026

Uh oh!

camc314 commented Jan 26, 2026 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

Sysix commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Stanzilla commented Jan 26, 2026

Uh oh!

camc314 commented Jan 26, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Jan 14, 2026 •

edited

Loading

Sysix commented Jan 14, 2026 •

edited

Loading

camc314 commented Jan 26, 2026 •

edited by graphite-app bot

Loading