fix(vscode): resolve binary paths with node resolver

[Sysix]

Refactored the search to use path.resolve instead of glob search with VSCode.
The VSCode snippet did some excludes in the background with search.excludes and/or other settings.
Now it should work without these restriction and hopefully

closes #17936
closes #17881
closes #17744

It will not search for globally installed oxlint/oxfmt. Created an extra issue for this: #18005

[Sysix]

• feat(vscode): fallback to globally installed oxlint/oxfmt packages #18007
• chore(vscode): format for vscode tests files #17971
• fix(vscode): resolve binary paths with node resolver #17970 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This pull request refactors binary path resolution in the VS Code extension to use Node.js's require.resolve instead of filesystem globbing. The change aims to simplify and potentially improve the reliability of locating oxlint and oxfmt binaries in node_modules.

Changes:

• Replaced workspace file globbing with require.resolve for binary discovery
• Updated runExecutable function to accept a nodeBinName parameter for better path pattern detection
• Simplified test helpers and removed file system operations from tests

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
editors/vscode/client/ConfigService.ts	Replaced file globbing with require.resolve and removed cancellation token logic
editors/vscode/client/tools/lsp_helper.ts	Added nodeBinName parameter and path pattern detection for Node.js binaries
editors/vscode/client/tools/linter.ts	Updated runExecutable call to pass "oxlint" as tool name
editors/vscode/client/tools/formatter.ts	Updated runExecutable call to pass "oxfmt" as tool name
editors/vscode/tests/unit/lsp_helper.spec.ts	Updated all test calls to include the new tool parameter
editors/vscode/tests/unit/ConfigService.spec.ts	Simplified test helpers and removed file system setup/teardown operations

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[rikbrown]

Confirming as an affected user in #17936, this fixes the problem for me (mac/pnpm).

[Sysix]

@connorshea / @Boshen: I think @camc314 is not available before the next release. Could you look into this stack :)? The most code was inspired by biome:
https://github.com/biomejs/biome-vscode/blob/ae9b6df2254d0ff8ee9d626554251600eb2ca118/src/locator.ts#L267-L339

[graphite-app]

Merge activity

• Jan 18, 3:43 PM UTC: Sysix added this pull request to the Graphite merge queue.
• Jan 18, 3:49 PM UTC: Merged by the Graphite merge queue.

[connorshea]

Speak of the devil and he shall appear :)