fix(linter/plugins): implement `context.parserPath` by overlookmotel · Pull Request #18644 · oxc-project/oxc

overlookmotel · 2026-01-28T01:56:38Z

Closes #18119. Implement context.parserPath. It evaluates to undefined, same as what ESLint does by default.

overlookmotel · 2026-01-28T01:56:52Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR implements the context.parserPath property for the oxlint plugin system, resolving issue #18119. Previously, accessing this property would throw an error, causing custom ESLint rules (like taiga-ui rules) to fail. The property now returns undefined instead, matching ESLint's behavior for this deprecated property.

Changes:

Modified context.parserPath to return undefined instead of throwing an error when accessed in file context
Maintained the error behavior when accessed in createOnce context
Updated tests to verify both the normal return value and the createOnce error handling

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
apps/oxlint/src-js/plugins/context.ts	Changed `parserPath` getter to return `undefined` and updated return type to `string \| undefined`
apps/oxlint/test/fixtures/context_properties/plugin.ts	Added test to verify `parserPath` returns `undefined`
apps/oxlint/test/fixtures/context_properties/output.snap.md	Updated snapshot to show `parserPath: undefined`
apps/oxlint/test/fixtures/createOnce/plugin.ts	Added test to verify error when accessing `parserPath` in `createOnce`
apps/oxlint/test/fixtures/createOnce/output.snap.md	Updated snapshot to include `parserPath` error messages and updated error count

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/oxlint/src-js/plugins/context.ts

Closes #18119. Implement `context.parserPath`. It evaluates to `undefined`, same as what ESLint does by default.

graphite-app · 2026-01-28T02:33:25Z

Merge activity

Jan 28, 2:33 AM UTC: Merged by the Graphite merge queue.

# Oxlint ### 💥 BREAKING CHANGES - b34a155 linter/plugins: [**BREAKING**] `RuleTester` set `context.filename` to absolute path (#18702) (overlookmotel) ### 🚀 Features - 1753209 linter/vscode: Run extension when JS configs are detected (#18832) (camc314) - c962dd2 linter/lsp: Implement support for oxlint.config.ts (#18826) (camc314) - da32203 linter: Auto generate oxlint.config.ts types (#18597) (camc314) - 19b4df7 oxlint: Introduce `defineConfig` helper (#18596) (camc314) - ea97231 linter: Implement `oxlint.config.ts` support (#17563) (camc314) - 17ca42d linter: Implement `react/no-multi-comp` rule. (#18794) (connorshea) - 88f30e0 linter/plugins: Move eslint compatible plugin conversion to `eslintCompatPlugin` function (#18791) (overlookmotel) - 2a72794 linter/plugins: `RuleTester` take `cwd` property (#18756) (overlookmotel) - 9f533db linter: Add `find_prev_token_within` method for token search (#18769) (camc314) - 772ea70 linter: Introduce `load_js_configs` napi callback (#18767) (camc314) - e9690c1 linter: Introduce `DiscoveredConfig` in preparation for JS configs (#18674) (camc314) - 558b588 linter/prefer-namespace-keyword: Move to correctness (#18733) (camc314) - 7a5c268 oxlint/lsp: Support `jsPlugins` (#17840) (Sysix) - c07497c linter/prefer-modern-dom-apis: Implement suggestion (#17965) (Mikhail Baev) - 8531bc9 linter: Implement `prefer-const` (#18687) (camchenry) - 8670b18 parser: Error on ambient class accessor implementations (#18592) (camc314) - 6b8a5ae linter: Add `eslint-plugin-import/no-nodejs-modules` rule (#18006) (Mikhail Baev) - 04f400d linter/no-duplicates: Add support for `considerQueryString` option (#18657) (camc314) - 3b7f260 linter/consistent-generic-constructor: Implement fixer (#18616) (camc314) - 794f9e4 linter/prefer-exponentation-operator: Implement suggestion (#18602) (camc314) - 773d916 linter: `eslint/sort_keys` ignore leading and trailing spreads in auto-fix (#18485) (Lonami) - 20d4ede linter: Implement `import/no-relative-parent-imports` rule (#18513) (Valentin Maerten) - 0da45ef vscode: Fallback to globally installed oxlint/oxfmt packages (#18007) (Sysix) ### 🐛 Bug Fixes - a3417b1 linter/plugins: Clear state when reloading workspace (#18837) (overlookmotel) - c879992 linter: Error on arrays passed in as config (#18822) (camc314) - 5c80422 linter/tsdown: Ensure relative path for globals import starts with `./` (#18820) (camc314) - 7419dfb linter: Remove invalid debug assersion, add test (#18819) (camc314) - 0ca6269 ci: Fix the repo path normalization logic for tests on Windows. (#18815) (connorshea) - c7b0a65 linter: Fix config option docs for `react/jsx-boolean-value` rule. (#18811) (connorshea) - cce374e linter/prefer-const: Replace entire declaration over just the `let` kw (#18814) (camc314) - 41f92d1 linter: Error when given config options for a lint rule that has no config options defined. (#18809) (connorshea) - 0867a36 linter/consistent-index-object-style: False positive with mapped + generic types (#18801) (camc314) - 1d34b42 linter: Fix 32 bit build (#18783) (camc314) - 95df577 linter/plugins: Handle error from `destroyWorkspace` (#18763) (overlookmotel) - b3261dc linter: Fix the curly rule config to enforce the shape of the config and emit correct docs (#18743) (connorshea) - d981978 linter/plugins: Use non-blocking mode when calling `destroyWorkspace` (#18762) (overlookmotel) - 3f43d4c linter: Accept bools as valid values for `fixable` (#18772) (camc314) - 005910a linter/plugins: Support plugins outside of workspace (#18755) (overlookmotel) - fd92711 vscode: Use `fsPath` for workspace mapping (#18728) (Sysix) - 358b2c1 linter/consistent-generic-constructors: Check bounds when searching for `:` token (#18745) (connorshea) - abd0c28 linter/capitalized-comments: Fix generated rule option docs (#18748) (connorshea) - d90a9f6 linter: Add more tests for `prefer-const`'s fixer and fix its invalid behavior. (#18747) (connorshea) - f82011b oxlint/lsp: Disable JS plugins support in LSP except in tests (#18727) (overlookmotel) - 94505c8 linter/jest: Change `prefer-spy-on` autofix to suggestion (#18152) (Ben Lowery) - 6ec1112 linter: Mark unused disable directive fix as suggestion (#18703) (ddmoney420) - 49609ec linter/no-useless-constructor: Consider argument transformation as used (#18706) (ddmoney420) - 40218de linter: Fix behavior of jsx-a11y/no-static-element-interactions rule. (#17817) (connorshea) - db9751d linter/no-html-link-for-pages: Handle `target=_blank` correctly (#18693) (camc314) - e440b78 linter/plugins: Pass all args to CFG event handlers when 2 rules use same handler (#18683) (overlookmotel) - b393430 linter/curly: Fix multi-or-nest and consistent conflict (#18660) (camc314) - 2e1fbc2 linter/plugins: Implement `context.parserPath` (#18644) (overlookmotel) - 34951ed linter/plugins: `filename` option takes precedence over `parserOptions.lang` in `RuleTester` (#18643) (overlookmotel) - 28df160 linter/plugins: Allow line number passed to `report` to be 0 (#18642) (overlookmotel) - 14fabec vscode: Use built-in `getWorkspaceFolder` for detecting the right workspace of a given uri (#18583) (Sysix) - 0ff4cea oxlint/cli: Report error when nested config could not be parsed (#18504) (Sysix) ### ⚡ Performance - 9862224 linter/plugins: Reduce cost of workspaces (#18758) (overlookmotel) - 6bc0bde linter: Remove string allocation (#18725) (overlookmotel) - 3a6b41e linter/plugins: Replace ESLint Traverser with lightweight traverseNode (#18529) (Rintaro Itokawa) ### 📚 Documentation - dd1a653 linter: Fix doc comment for ignoreStateless config option. (#18808) (connorshea) - 5909085 linter/plugins: Add doc comments (#18753) (overlookmotel) - ffe53a3 linter: Update lint function docs (#18766) (camc314) - b82faec linter: Glob for any css module for no-unassigned-import (#18713) (Ben Stickley) - cd86347 linter: Mark some react rules as unsupported, misc docs improvements (#18617) (connorshea) - 23401d8 linter: Update fixes and suggestions status for tsgolint rules (#18619) (camchenry) # Oxfmt ### 🚀 Features - ee30de9 oxfmt: Add config migration from biome (#18638) (Luca Fischer) ### 🐛 Bug Fixes - e754b18 oxfmt/migrate-prettier: Set `experimentalSortPackagejson: false` by default (#18831) (leaysgur) - a83c266 formatter: Keep decorated function pattern hugged when params break (#18830) (Dunqing) - 0c8efe1 formatter: Quote numeric property keys with `quoteProps: consistent` (#18803) (Dunqing) - 9c14c3e formatter: Ignore comment does not work for sequence expressions in arrow function body (#18799) (Dunqing) - 54984ae formatter: Handle leading comments in arrow function sequence expressions (#18798) (Dunqing) - 61bb2b5 formatter: Correctly expand JSX returned from arrow callbacks in JSX expression containers (#18797) (Dunqing) - 34ee194 formatter: Tailwindcss sorting doesn't work for object property keys (#18773) (Dunqing) - 48f1e35 oxfmt: Prevent ThreadsafeFunction crash on Node.js exit (#18723) (Boshen) - e96adca formatter: Follow Prettier's approach for for-in initializer parentheses (#18695) (Dunqing) - 1215a6f formatter: Preserve quote for class property key in TypeScript (#18692) (Dunqing) - 059acae formatter: Incorrect comments placement for union type in `TSTypeIntersection` (#18690) (Dunqing) - c3d05c1 formatter,oxfmt: Handle CRLF with embedded formatting (#18686) (leaysgur) - 7cb3085 formatter: Preserve comments on rest elements (#18649) (Dunqing) - 21984dd formatter: Preserve type cast comments on rest parameters (#18648) (Dunqing) - 2f70254 formatter: Don't add extra semicolon on suppressed class properties (#18631) (Dunqing) - ac1ff4e oxfmt: Use `empty_line` IR for empty xxx-in-js line (#18623) (leaysgur) - 8f76900 oxfmt: Dedent xxx-in-js templates before calling prettier (#18622) (leaysgur) - 6b726ef oxfmt: Trim whitespace only xxx-in-js templates (#18621) (leaysgur) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Jan 28, 2026

github-actions bot added the C-bug Category - Bug label Jan 28, 2026

overlookmotel marked this pull request as ready for review January 28, 2026 02:00

overlookmotel requested a review from camc314 as a code owner January 28, 2026 02:00

Copilot AI review requested due to automatic review settings January 28, 2026 02:00

Copilot started reviewing on behalf of overlookmotel January 28, 2026 02:00 View session

overlookmotel mentioned this pull request Jan 28, 2026

linter: implement FILE_CONTEXT.parserPath in jsPlugins #18119

Closed

overlookmotel self-assigned this Jan 28, 2026

Copilot AI reviewed Jan 28, 2026

View reviewed changes

apps/oxlint/src-js/plugins/context.ts Show resolved Hide resolved

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 28, 2026

graphite-app bot changed the base branch from om/01-27-fix_linter_plugins_filename_option_takes_precedence_over_parseroptions.lang_in_ruletester_ to graphite-base/18644 January 28, 2026 02:05

graphite-app bot force-pushed the graphite-base/18644 branch from 57a6756 to 28df160 Compare January 28, 2026 02:10

graphite-app bot force-pushed the om/01-27-fix_linter_plugins_implement_context.parserpath_ branch from 31390fb to 841c499 Compare January 28, 2026 02:10

graphite-app bot changed the base branch from graphite-base/18644 to main January 28, 2026 02:11

graphite-app bot force-pushed the om/01-27-fix_linter_plugins_implement_context.parserpath_ branch from 841c499 to 5902f73 Compare January 28, 2026 02:11

overlookmotel changed the base branch from main to graphite-base/18644 January 28, 2026 02:20

overlookmotel changed the base branch from graphite-base/18644 to om/01-27-fix_linter_plugins_filename_option_takes_precedence_over_parseroptions.lang_in_ruletester_ January 28, 2026 02:20

overlookmotel force-pushed the om/01-27-fix_linter_plugins_implement_context.parserpath_ branch from 5902f73 to 7ed9d2e Compare January 28, 2026 02:20

overlookmotel mentioned this pull request Jan 28, 2026

test(linter/plugins): add eslint-plugin-sonarjs to conformance tests #18646

Merged

Base automatically changed from om/01-27-fix_linter_plugins_filename_option_takes_precedence_over_parseroptions.lang_in_ruletester_ to main January 28, 2026 02:23

fix(linter/plugins): implement context.parserPath (#18644)

2e1fbc2

Closes #18119. Implement `context.parserPath`. It evaluates to `undefined`, same as what ESLint does by default.

graphite-app bot force-pushed the om/01-27-fix_linter_plugins_implement_context.parserpath_ branch from 7ed9d2e to 2e1fbc2 Compare January 28, 2026 02:26

graphite-app bot merged commit 2e1fbc2 into main Jan 28, 2026
19 checks passed

graphite-app bot deleted the om/01-27-fix_linter_plugins_implement_context.parserpath_ branch January 28, 2026 02:33

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 28, 2026

Boshen mentioned this pull request Feb 2, 2026

release(apps): oxlint v1.43.0 && oxfmt v0.28.0 #18843

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fix(linter/plugins): implement `context.parserPath`#18644

fix(linter/plugins): implement `context.parserPath`#18644
graphite-app[bot] merged 1 commit intomainfrom
om/01-27-fix_linter_plugins_implement_context.parserpath_

overlookmotel commented Jan 28, 2026 •

edited

Loading

Uh oh!

overlookmotel commented Jan 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

overlookmotel commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

graphite-app bot commented Jan 28, 2026

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

overlookmotel commented Jan 28, 2026 •

edited

Loading

overlookmotel commented Jan 28, 2026 •

edited

Loading