Skip to content

refactor(oxfmt): Minimize setBlocking(true) workaround scope#17974

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope
Jan 14, 2026
Merged

refactor(oxfmt): Minimize setBlocking(true) workaround scope#17974
graphite-app[bot] merged 1 commit intomainfrom
01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope

Conversation

@leaysgur
Copy link
Member

Follow up #17950

Copilot AI review requested due to automatic review settings January 14, 2026 00:41
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 14, 2026
Copy link
Member Author

leaysgur commented Jan 14, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the setBlocking(true) workaround to minimize its scope by only applying it when stdout is piped (non-TTY), and removes the stderr workaround entirely. This is a follow-up to issue #17950.

Changes:

  • Added TTY check to conditionally apply the setBlocking(true) workaround only when stdout is piped
  • Removed the setBlocking(true) call for stderr
  • Updated comments to clarify that the issue occurs specifically with non-TTY stdout and when using pipes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur requested a review from Dunqing January 14, 2026 01:23
@leaysgur leaysgur changed the title refactor(oxfmt): Minimize setBlocking(true) workaround scope refactor(oxfmt): Minimize setBlocking(true) workaround scope Jan 14, 2026
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope branch from b3002a8 to 1c1da22 Compare January 14, 2026 05:10
@graphite-app graphite-app bot merged commit 1c1da22 into main Jan 14, 2026
18 checks passed
@graphite-app graphite-app bot deleted the 01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope branch January 14, 2026 05:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants