refactor(oxfmt): Minimize setBlocking(true) workaround scope#17974
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the setBlocking(true) workaround to minimize its scope by only applying it when stdout is piped (non-TTY), and removes the stderr workaround entirely. This is a follow-up to issue #17950.
Changes:
- Added TTY check to conditionally apply the
setBlocking(true)workaround only when stdout is piped - Removed the
setBlocking(true)call for stderr - Updated comments to clarify that the issue occurs specifically with non-TTY stdout and when using pipes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
setBlocking(true) workaround scope
Merge activity
|
b3002a8 to
1c1da22
Compare

Follow up #17950