fix(oxfmt): Do not wrap with block_indent() if format_embedded fails#17975
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 14, 2026
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
changed the title
block_indent() if format_embedded fails
Dunqing
approved these changes
Jan 14, 2026
Member
Merge activity
|
…ils (#17975) Fixes #17948 and may fix `next.js` repo diffs. => Confirmed all xxx-in-js diffs are resolved ✨ --- When Prettier fails to format embedded code (e.g., valid `css` tag but with invalid content), the previous implementation returned the original code as a successful result. This caused issues because `block_indent` is always added (assuming Prettier has normalized root indentation). As a result, indentation/newlines grow infinitely on each format run.
graphite-app
bot
force-pushed
the
01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope
branch
from
b3002a8 to
1c1da22
Compare
graphite-app
bot
force-pushed
the
01-14-fix_oxfmt_do_not_wrap_with_indent_if_format_embedded_fails
branch
from
0a0d37c to
efacb13
Compare
Base automatically changed from
01-14-refactor_oxfmt_minimize_setblocking_true_workaround_scope
to
main
January 14, 2026 05:17
graphite-app
bot
deleted the
01-14-fix_oxfmt_do_not_wrap_with_indent_if_format_embedded_fails
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17948 and may fix
next.jsrepo diffs. => Confirmed all xxx-in-js diffs are resolved ✨When Prettier fails to format embedded code (e.g., valid
csstag but with invalid content), the previous implementation returned the original code as a successful result.This caused issues because
block_indentis always added (assuming Prettier has normalized root indentation).As a result, indentation/newlines grow infinitely on each format run.