fix(oxfmt): Use std(out/err)._handle.setBlocking(true) to handle WouldBlock error in Rust#17950
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 13, 2026
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
changed the title
std(out/err)._handle.setBlocking(true) to handle WouldBlock error in Rust
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a WouldBlock error that occurs when writing large output in Rust through NAPI bindings. The issue arises because Node.js sets stdio to non-blocking mode by default, which conflicts with Rust's blocking I/O operations when using --stdin-filepath.
Changes:
- Added code to set stdout and stderr to blocking mode before calling Rust NAPI bindings
- Added comprehensive comments explaining the fix and why it differs from the
yargs/set-blockingapproach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
force-pushed
the
01-13-fix_oxfmt_use_stdout_err_setblocking_true_to_handle_wouldblock_error
branch
from
dff70f4 to
82bc59a
Compare
leaysgur
force-pushed
the
01-13-fix_oxfmt_use_stdout_err_setblocking_true_to_handle_wouldblock_error
branch
from
82bc59a to
6dad761
Compare
Dunqing
approved these changes
Jan 13, 2026
Member
Merge activity
|
graphite-app
bot
force-pushed
the
01-13-fix_oxfmt_use_stdout_err_setblocking_true_to_handle_wouldblock_error
branch
from
6dad761 to
9d96cc6
Compare
graphite-app
bot
deleted the
01-13-fix_oxfmt_use_stdout_err_setblocking_true_to_handle_wouldblock_error
branch
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17939, closes #17943 and #17946.