refactor(oxlint/lsp): pass ExternalLinter/-Store to nested config search#17808
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 8, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
force-pushed
the
01-08-refactor_oxlint_lsp_pass_externallinter_-store_to_nested_config_search
branch
from
1522106 to
abc83bc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the LSP server linter to pass ExternalLinter and ExternalPluginStore to the nested config search function, aligning it with CLI behavior. Since --lsp uses None for external_linter, this is a pure refactoring with no behavioral changes.
Key changes:
- Moved
ExternalPluginStoreinitialization earlier in the flow to enable passing it to nested config creation - Changed
create_nested_configs()from a static method to an instance method to accessself.external_linter - Updated nested config creation to use the shared
ExternalPluginStoreinstead of creating local instances
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Jan 8, 2026
Member
Author
Merge activity
|
…earch (#17808) Because `--lsp` is using `None` for `external_linter`, this is just a refactoring, aligning the future behavior with CLI.
graphite-app
bot
force-pushed
the
01-08-refactor_oxlint_lsp_pass_externallinter_-store_to_nested_config_search
branch
from
abc83bc to
36b82ec
Compare
graphite-app
bot
deleted the
01-08-refactor_oxlint_lsp_pass_externallinter_-store_to_nested_config_search
branch
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
--lspis usingNoneforexternal_linter, this is just a refactoring, aligning the future behavior with CLI.