Merged
Conversation
leaysgur
changed the base branch from
01-13-fix_oxfmt_use_stdout_err_setblocking_true_to_handle_wouldblock_error
to
graphite-base/17953
github-actions
bot
added
A-cli
leaysgur
force-pushed
the
01-13-refactor_oxfmt_misc_fixes
branch
from
4c1c59f to
5077b4f
Compare
leaysgur
force-pushed
the
graphite-base/17953
branch
from
6dad761 to
c4c55cc
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
leaysgur
force-pushed
the
01-13-refactor_oxfmt_misc_fixes
branch
from
5077b4f to
5f8d14b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs pure refactoring to clean up code in the oxfmt formatter by fixing compiler warnings and removing unnecessary indirection.
Changes:
- Removed unnecessary
Option<ExternalFormatter>wrapper fromStdinRunner, requiring the formatter to be passed directly to the constructor - Fixed unused variable warning for
sort_package_jsonwhen building without thenapifeature by using conditional compilation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/oxfmt/src/stdin/mod.rs |
Removed Option<> wrapper and builder method, updated new() to accept ExternalFormatter directly |
apps/oxfmt/src/main_napi.rs |
Updated StdinRunner::new() call site to pass external_formatter as constructor argument |
apps/oxfmt/src/core/config.rs |
Added conditional compilation to extract sort_package_json only when napi feature is enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dunqing
approved these changes
Jan 13, 2026
Contributor
Merge activity
|
Pure refactoring; - Fix unused var warnings with `--no-default-features` - Remove useless `Option<>`
graphite-app
bot
force-pushed
the
01-13-refactor_oxfmt_misc_fixes
branch
from
5f8d14b to
82c6c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactoring;
--no-default-featuresOption<>