Skip to content

fix(linter/no-promise-executor-return): check if Promise is the global one#17949

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-12-fix_lintr_no-promise-executor-return_check_if_promise_is_the_global_one
Jan 14, 2026
Merged

fix(linter/no-promise-executor-return): check if Promise is the global one#17949
graphite-app[bot] merged 1 commit intomainfrom
01-12-fix_lintr_no-promise-executor-return_check_if_promise_is_the_global_one

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jan 13, 2026

Previously we only checked if the identifier was called Promise. Now, we also check if it's the global reference or a locally bound reference.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jan 13, 2026
Copy link
Member Author

camchenry commented Jan 13, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry changed the title fix(lintr/no-promise-executor-return): check if Promise is the global one fix(linter/no-promise-executor-return): check if Promise is the global one Jan 13, 2026
@camchenry camchenry marked this pull request as ready for review January 13, 2026 04:23
@camchenry camchenry requested a review from camc314 as a code owner January 13, 2026 04:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1


Comparing 01-12-fix_lintr_no-promise-executor-return_check_if_promise_is_the_global_one (f0fec5d) with 01-12-fix_linter_no-await-in-loop_add_support_for_await_using_ (088e6c1)

Open in CodSpeed

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot changed the base branch from 01-12-fix_linter_no-await-in-loop_add_support_for_await_using_ to graphite-base/17949 January 14, 2026 11:41
@camc314 camc314 self-assigned this Jan 14, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
Copy link
Contributor

camc314 commented Jan 14, 2026

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/17949 to main January 14, 2026 11:47
…bal one (#17949)

Previously we only checked if the identifier was called `Promise`. Now, we also check if it's the global reference or a locally bound reference.
@graphite-app graphite-app bot force-pushed the 01-12-fix_lintr_no-promise-executor-return_check_if_promise_is_the_global_one branch from f0fec5d to dbe06d8 Compare January 14, 2026 11:47
@graphite-app graphite-app bot merged commit dbe06d8 into main Jan 14, 2026
20 checks passed
@graphite-app graphite-app bot deleted the 01-12-fix_lintr_no-promise-executor-return_check_if_promise_is_the_global_one branch January 14, 2026 11:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants