Skip to content

fix(linter/no-promise-executor-return): check if Promise is the global one #17949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 14, 2026
Merged

fix(linter/no-promise-executor-return): check if Promise is the global one #17949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions crates/oxc_linter/src/rules/eslint/no_promise_executor_return.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,12 @@ impl Rule for NoPromiseExecutorReturn {
return;
};

if !new_expr.callee.is_specific_id("Promise") {
// Check if the callee is `Promise` and it's a reference to the global `Promise`
let Some(ident) = new_expr.callee.get_identifier_reference() else {
return;
};

if ident.name != "Promise" || !ctx.is_reference_to_global_variable(ident) {
return;
}

Expand Down Expand Up @@ -262,15 +267,14 @@ fn test() {
// globals are not supported in tests.
// ("/* globals Promise:off */ new Promise(function (resolve, reject) { return 1; });", None)
// ("new Promise((resolve, reject) => { return 1; });", None), // { "globals": { "Promise": "off" } }
// TODO: Fix these tests.
// ("let Promise; new Promise(function (resolve, reject) { return 1; });", None),
// ("function f() { new Promise((resolve, reject) => { return 1; }); var Promise; }", None),
// ("function f(Promise) { new Promise((resolve, reject) => 1); }", None),
// (
// "if (x) { const Promise = foo(); new Promise(function (resolve, reject) { return 1; }); }",
// None,
// ),
// ("x = function Promise() { new Promise((resolve, reject) => { return 1; }); }", None),
("let Promise; new Promise(function (resolve, reject) { return 1; });", None),
("function f() { new Promise((resolve, reject) => { return 1; }); var Promise; }", None),
("function f(Promise) { new Promise((resolve, reject) => 1); }", None),
(
"if (x) { const Promise = foo(); new Promise(function (resolve, reject) { return 1; }); }",
None,
),
("x = function Promise() { new Promise((resolve, reject) => { return 1; }); }", None),
("new Promise(function (resolve, reject) { return; });", None),
("new Promise(function (resolve, reject) { reject(new Error()); return; });", None),
("new Promise(function (resolve, reject) { if (foo) { return; } });", None),
Expand Down
Loading