fix(linter/no-await-in-loop): add support for await using

[camchenry]

Updating this rule to account for an await using in the loop and in the loop condition. I did use Copilot to help update this rule based on the original source and then edited afterwards for style.

[camchenry]

• fix(linter/prefer-destructuring): fix rule to exclude using and await using #17952
• feat(linter/no-useless-rename): add automatic fix #17951
• fix(linter/no-promise-executor-return): check if Promise is the global one #17949
• fix(linter/no-await-in-loop): add support for await using #17947 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks¹

---

_{Comparing 01-12-fix_linter_no-await-in-loop_add_support_for_await_using_ (088e6c1) with main (6b29bd1)²}

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (e795a0a) during the generation of this report, so 6b29bd1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

This pull request adds support for detecting await using declarations in the no-await-in-loop ESLint rule. The rule previously detected await expressions and for await...of statements inside loops, and now also detects await using declarations which are problematic in the same way.

Changes:

• Added handling for await using variable declarations in loops
• Updated the is_looped function to accept a node parameter instead of just a span, enabling detection of await using in for-in/of loop conditions
• Added test cases covering await using in while loops, for loops, and for-of loops

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/eslint/no_await_in_loop.rs	Added support for detecting await using declarations in loops, including handling for loop bodies and for-in/of left positions
crates/oxc_linter/src/snapshots/eslint_no_await_in_loop.snap	Added test snapshots for three new test cases covering await using in different loop contexts
crates/oxc_linter/src/generated/rule_runner_impls.rs	Added VariableDeclaration to the NODE_TYPES bitset for the rule

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Jan 14, 11:41 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 14, 11:41 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Jan 14, 11:46 AM UTC: Merged by the Graphite merge queue.