refactor(formatter): rename write folder to print

[Dunqing]

This is what I have been wanting to change for a long time, since I worked on the formatter.

The reason is:

The formatter has a macro called write, which is used throughout the entire formatting process. Additionally, the formatter has a write folder that includes all formatting logic for the AST nodes, so we have two different things called write.

That confuses us when you have to import that write macro and also need to import other functions from other AST node formatting files

use crate::{
    write, // This is a macro
    write::{ // This is a write folder, we wrote all formatting logic for all AST in it
        arrow_function_expression::FormatMaybeCachedFunctionBody, semicolon::OptionalSemicolon,
    },
};

Not only that!! In VSCode, the rust-analyzer can help us automatically import functions from other files.

When you don't import write marco yet, your imports is like this

use crate::{
    write::{ // This is a write folder, we wrote all formatting logic for all AST in it
        arrow_function_expression::FormatMaybeCachedFunctionBody, semicolon::OptionalSemicolon,
    },
};

And, when typing write somewhere, and rust-analyzer triggers to import the write macro. That's very cool, but unfortunately, since you already have imported something from the write folder, it would import self from the write folder.

So the final imports is:

use crate::{
    write::{ // This is a write folder, we wrote all formatting logic for all AST in it
        self, arrow_function_expression::FormatMaybeCachedFunctionBody, semicolon::OptionalSemicolon,
//      ^^^^ Oh, no, it is totally different things
    },
};

To avoid these two bad things, I renamed the write folder to print, making it cleaner and avoiding struggling with a wave of annoying errors.

The wrong write imported is like

[Dunqing]

• refactor(formatter): rename write folder to print #17919 👈 (View in Graphite)
• refactor(formatter): move call-like expression formatting implementation to call_like_expression module #17918
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks¹

---

_{Comparing 01-12-refactor_formatter_rename_write_folder_to_print (667659a) with 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module (460248a)}

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[leaysgur]

💯

[leaysgur]

Merge activity

• Jan 13, 9:28 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 13, 9:28 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Jan 13, 9:35 AM UTC: Merged by the Graphite merge queue.