Skip to content

Comments

feat(formatter): add oxfmt-ignore ignore comment support#17916

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support
Jan 13, 2026
Merged

feat(formatter): add oxfmt-ignore ignore comment support#17916
graphite-app[bot] merged 1 commit intomainfrom
01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 12, 2026

close: #17915

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jan 12, 2026
Copy link
Member Author

Dunqing commented Jan 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing requested a review from Boshen January 12, 2026 07:54
@Dunqing Dunqing force-pushed the 01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support branch from 962b3f2 to 8fd8688 Compare January 12, 2026 07:55
@Dunqing Dunqing marked this pull request as ready for review January 12, 2026 07:55
Copilot AI review requested due to automatic review settings January 12, 2026 07:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for oxfmt-ignore as the primary suppression comment for the Oxc formatter, while maintaining backward compatibility with prettier-ignore. The change aligns the formatter with Oxc's branding and provides a more intuitive comment directive for users.

Changes:

  • Added oxfmt-ignore as the primary suppression comment
  • Maintained backward compatibility with prettier-ignore
  • Updated documentation to reflect both supported comment types

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support (9cf0559) with main (f1fb048)1

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks2

Footnotes

  1. No successful run was found on main (f71243f) during the generation of this report, so f1fb048 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Update docs; this is available only for JS/TS.

(It shouldn't be impossible to reimplement comment detection in the printer implementation for all of Prettier's built-in plugins tho...)

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
Copy link
Member

leaysgur commented Jan 13, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support branch from 9cf0559 to c4c55cc Compare January 13, 2026 00:52
@graphite-app graphite-app bot merged commit c4c55cc into main Jan 13, 2026
20 checks passed
@graphite-app graphite-app bot deleted the 01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support branch January 13, 2026 00:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatter: oxfmt-ignore

3 participants