refactor(formatter): move call-like expression formatting implementation to call_like_expression module#17918
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
9cf0559 to
f71243f
Compare
6427b48 to
fcadc6a
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
fcadc6a to
460248a
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the formatter code by moving call-like expression formatting implementations from the main write/mod.rs file into a dedicated call_like_expression module for better code organization and readability.
Changes:
- Moved
CallExpression,NewExpression, andImportExpressionformatting implementations to a newcall_like_expressionmodule - Reorganized argument formatting code into
call_like_expression/argument.rssubmodule - Cleaned up unused imports in
write/mod.rs
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/oxc_formatter/src/write/mod.rs |
Removed call-like expression implementations and updated module declarations; cleaned up unused imports |
crates/oxc_formatter/src/write/import_expression.rs |
Deleted file - code moved to call_like_expression/mod.rs |
crates/oxc_formatter/src/write/call_like_expression/mod.rs |
New file containing CallExpression, NewExpression, and ImportExpression formatting implementations |
crates/oxc_formatter/src/write/call_like_expression/argument.rs |
Reorganized imports for better readability while maintaining all necessary dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
…ion to call_like_expression module (#17918) Pure refactor, just moving and organizing code to make it more readable. Move the following formatting parts to `call_like_expression` module - CallExpression - NewExpression - ImportExpression Moved to `call_like_expression/arguments` - Vec<'a, Argument<'a>> - Argument<'a>
460248a to
4d5e530
Compare

Pure refactor, just moving and organizing code to make it more readable.
Move the following formatting parts to
call_like_expressionmoduleMoved to
call_like_expression/arguments