Skip to content

refactor(formatter): move call-like expression formatting implementation to call_like_expression module#17918

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module
Jan 13, 2026
Merged

refactor(formatter): move call-like expression formatting implementation to call_like_expression module#17918
graphite-app[bot] merged 1 commit intomainfrom
01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 12, 2026

Pure refactor, just moving and organizing code to make it more readable.

Move the following formatting parts to call_like_expression module

  • CallExpression
  • NewExpression
  • ImportExpression

Moved to call_like_expression/arguments

  • Vec<'a, Argument<'a>>
  • Argument<'a>

@github-actions github-actions bot added A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 12, 2026
Copy link
Member Author

Dunqing commented Jan 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the base branch from 01-12-feat_formatter_add_oxfmt-ignore_ignore_comment_support to graphite-base/17918 January 12, 2026 08:22
@Dunqing Dunqing force-pushed the graphite-base/17918 branch from 9cf0559 to f71243f Compare January 12, 2026 08:22
@Dunqing Dunqing force-pushed the 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module branch from 6427b48 to fcadc6a Compare January 12, 2026 08:23
@Dunqing Dunqing changed the base branch from graphite-base/17918 to main January 12, 2026 08:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module (460248a) with main (f1fb048)1

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks2

Footnotes

  1. No successful run was found on main (f71243f) during the generation of this report, so f1fb048 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing marked this pull request as ready for review January 12, 2026 08:34
Copilot AI review requested due to automatic review settings January 12, 2026 08:34
@Dunqing Dunqing force-pushed the 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module branch from fcadc6a to 460248a Compare January 12, 2026 08:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the formatter code by moving call-like expression formatting implementations from the main write/mod.rs file into a dedicated call_like_expression module for better code organization and readability.

Changes:

  • Moved CallExpression, NewExpression, and ImportExpression formatting implementations to a new call_like_expression module
  • Reorganized argument formatting code into call_like_expression/argument.rs submodule
  • Cleaned up unused imports in write/mod.rs

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File Description
crates/oxc_formatter/src/write/mod.rs Removed call-like expression implementations and updated module declarations; cleaned up unused imports
crates/oxc_formatter/src/write/import_expression.rs Deleted file - code moved to call_like_expression/mod.rs
crates/oxc_formatter/src/write/call_like_expression/mod.rs New file containing CallExpression, NewExpression, and ImportExpression formatting implementations
crates/oxc_formatter/src/write/call_like_expression/argument.rs Reorganized imports for better readability while maintaining all necessary dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Dunqing Dunqing requested a review from leaysgur January 13, 2026 08:53
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 13, 2026

Merge activity

…ion to call_like_expression module (#17918)

Pure refactor, just moving and organizing code to make it more readable.

Move the following formatting parts to `call_like_expression` module

- CallExpression
- NewExpression
- ImportExpression

Moved to `call_like_expression/arguments`
- Vec<'a, Argument<'a>>
- Argument<'a>
@graphite-app graphite-app bot force-pushed the 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module branch from 460248a to 4d5e530 Compare January 13, 2026 09:28
@graphite-app graphite-app bot merged commit 4d5e530 into main Jan 13, 2026
20 checks passed
@graphite-app graphite-app bot deleted the 01-12-refactor_formatter_move_call-like_expression_formatting_implementation_to_call_like_expression_module branch January 13, 2026 09:34
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants