refactor(linter/no-constant-condition): add label to span and better help text

[camchenry]

Made the help text more specific, and added a short label to the span that briefly states the problem.

[camchenry]

• feat(linter/no-invalid-regexp): add labels and help text to flag diagnostics #17865
• feat(linter/no-ex-assign): improve diagnostic with more detail #17864
• refactor(linter/no-delete-var): fix capitalization in diagnostic #17863
• refactor(linter/no-dupe-else-if): add labels to spans and improve help text #17862
• refactor(linter/no-control-regex): move help text to character spans #17861
• refactor(linter/no-constant-condition): add label to span and better help text #17860 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR refactors the no-constant-condition linter rule to add a descriptive label to diagnostic spans and improve the help message text.

Changes:

• Updated help text from "Constant expression as a test condition is not allowed" to "Update the condition to not be constant, or remove the condition entirely"
• Added a span label stating "this expression will always evaluate as true"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/eslint/no_constant_condition.rs	Modified diagnostic to add span label and updated help text
crates/oxc_linter/src/snapshots/eslint_no_constant_condition.snap	Regenerated snapshot reflecting the new diagnostic format with label and help text across 135+ test cases

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-10-refactor_linter_no-constant-condition_add_label_to_span_and_better_help_text (9281247) with main (e3c7d0b)¹}

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks²

Footnotes

1. No successful run was found on main (43d7f05) during the generation of this report, so e3c7d0b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Jan 11, 5:12 AM UTC: camchenry added this pull request to the Graphite merge queue.
• Jan 11, 5:18 AM UTC: Merged by the Graphite merge queue.