Skip to content

Comments

refactor(linter/no-dupe-else-if): add labels to spans and improve help text#17862

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text
Jan 11, 2026
Merged

refactor(linter/no-dupe-else-if): add labels to spans and improve help text#17862
graphite-app[bot] merged 1 commit intomainfrom
01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Jan 11, 2026

Add labels to the spans to make it clear which branch is executed and which one is not.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 11, 2026
Copy link
Member Author

camchenry commented Jan 11, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 11, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text (a6baa77) with 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans (a7e8cd5)

Summary

✅ 4 untouched benchmarks
⏩ 41 skipped benchmarks1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry changed the base branch from 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans to graphite-base/17862 January 11, 2026 04:16
@camchenry camchenry force-pushed the 01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text branch from 635f4e3 to a6baa77 Compare January 11, 2026 04:45
@camchenry camchenry force-pushed the graphite-base/17862 branch from 510bf23 to a7e8cd5 Compare January 11, 2026 04:45
@camchenry camchenry changed the base branch from graphite-base/17862 to 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans January 11, 2026 04:45
@camchenry camchenry marked this pull request as ready for review January 11, 2026 04:46
@camchenry camchenry requested a review from camc314 as a code owner January 11, 2026 04:46
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 11, 2026

Merge activity

…p text (#17862)

Add labels to the spans to make it clear which branch is executed and which one is not.
@graphite-app graphite-app bot force-pushed the 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans branch from a7e8cd5 to 7365e5c Compare January 11, 2026 05:13
@graphite-app graphite-app bot force-pushed the 01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text branch from a6baa77 to c085c4d Compare January 11, 2026 05:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 11, 2026
Base automatically changed from 01-10-refactor_linter_no-control-regex_move_help_text_to_character_spans to main January 11, 2026 05:20
@graphite-app graphite-app bot merged commit c085c4d into main Jan 11, 2026
21 checks passed
@graphite-app graphite-app bot deleted the 01-10-refactor_linter_no-dupe-else-if_add_labels_to_spans_and_improve_help_text branch January 11, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant