Skip to content

refactor(linter/no-constant-condition): add label to span and better help text #17860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 11, 2026
Merged

refactor(linter/no-constant-condition): add label to span and better help text #17860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_constant_condition.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ use crate::{AstNode, ast_util::IsConstant, context::LintContext, rule::Rule};

fn no_constant_condition_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Unexpected constant condition")
.with_help("Constant expression as a test condition is not allowed")
.with_label(span)
.with_help("Update the condition to not be constant, or remove the condition entirely")
.with_label(span.label("this expression will always evaluate to the same value"))
}

#[derive(Debug, Default, Clone, PartialEq, JsonSchema, Deserialize, Serialize)]
Expand Down
Loading
Loading