Skip to content

perf(semantic): remove enter_kind#17439

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_remove_enter_kind_
Dec 28, 2025
Merged

perf(semantic): remove enter_kind#17439
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_remove_enter_kind_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2025

Ref #18098

Copy link
Contributor Author

camc314 commented Dec 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #17439 will not alter performance

Comparing c/12-27-perf_semantic_remove_enter_kind_ (17f868b) with c/12-27-perf_semantic_inline_enter_kind_for_continuestatement_ (781625b)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on c/12-27-perf_semantic_inline_enter_kind_for_continuestatement_ (695604e) during the generation of this report, so c409d8d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 28, 2025

Merge activity

  • Dec 28, 8:23 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 28, 8:40 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #17436.
  • Dec 28, 8:40 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #17436.
  • Dec 28, 9:56 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 28, 9:57 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Dec 28, 9:57 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 28, 10:02 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 28, 10:09 PM UTC: Merged by the Graphite merge queue.

@camc314 camc314 self-assigned this Dec 28, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_continuestatement_ branch from 781625b to 695604e Compare December 28, 2025 21:56
@camc314 camc314 force-pushed the c/12-27-perf_semantic_remove_enter_kind_ branch from 526a408 to 17f868b Compare December 28, 2025 21:56
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_continuestatement_ branch from 695604e to 19b437b Compare December 28, 2025 22:02
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_remove_enter_kind_ branch from 17f868b to 5fa85be Compare December 28, 2025 22:02
Base automatically changed from c/12-27-perf_semantic_inline_enter_kind_for_continuestatement_ to main December 28, 2025 22:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@graphite-app graphite-app bot merged commit 5fa85be into main Dec 28, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_semantic_remove_enter_kind_ branch December 28, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant