Skip to content

perf(semantic): inline enter_kind for TSTypeReference#17432

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_
Dec 28, 2025
Merged

perf(semantic): inline enter_kind for TSTypeReference#17432
graphite-app[bot] merged 1 commit intomainfrom
c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 28, 2025

Ref #18098

@github-actions github-actions bot added A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 28, 2025
Copy link
Contributor Author

camc314 commented Dec 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 self-assigned this Dec 28, 2025
@camc314 camc314 marked this pull request as ready for review December 28, 2025 16:16
@camc314 camc314 requested a review from Dunqing as a code owner December 28, 2025 16:16
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
Copy link
Contributor Author

camc314 commented Dec 28, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #17432 will not alter performance

Comparing c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_ (d16f211) with c/12-27-perf_semantic_inline_enter_kind_for_tsclassimplements_ (c2e9e05)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tsclassimplements_ branch from c2e9e05 to 99c6184 Compare December 28, 2025 16:25
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_ branch 2 times, most recently from 818d6be to eaf8531 Compare December 28, 2025 16:25
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tsclassimplements_ branch from 99c6184 to 8238b83 Compare December 28, 2025 16:25
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tsclassimplements_ branch from 8238b83 to ea2d639 Compare December 28, 2025 16:26
@graphite-app graphite-app bot force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_ branch from eaf8531 to a1cd171 Compare December 28, 2025 16:27
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
Base automatically changed from c/12-27-perf_semantic_inline_enter_kind_for_tsclassimplements_ to main December 28, 2025 16:33
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
@camc314 camc314 force-pushed the c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_ branch from a1cd171 to d08356e Compare December 28, 2025 20:01
Copilot AI review requested due to automatic review settings December 28, 2025 20:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes performance by inlining the enter_kind logic for TSTypeReference nodes directly into a custom visitor method. This avoids the overhead of the match statement in enter_kind for this frequently-visited TypeScript AST node type.

Key changes:

  • Added custom visit_ts_type_reference method that sets reference flags inline
  • Removed the TSTypeReference case from the enter_kind match statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot merged commit d08356e into main Dec 28, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/12-27-perf_semantic_inline_enter_kind_for_tstypereference_ branch December 28, 2025 20:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants